Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The client_options.api_endpoint parameter is being ignored in both PublisherClient and SubscriberClient #61

Closed
pradn opened this issue Mar 25, 2020 · 0 comments · Fixed by #59
Closed

The client_options.api_endpoint parameter is being ignored in both PublisherClient and SubscriberClient #61

pradn opened this issue Mar 25, 2020 · 0 comments · Fixed by #59
Assignees
@yoshi-automation
Labels
api: pubsub Issues related to the googleapis/python-pubsub API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@pradn
Copy link
Contributor

pradn commented Mar 25, 2020 •
edited

This bug prevents users from using regional endpoints. It also makes it harder to test code against nonprod endpoints.
@product-auto-label product-auto-label bot added the api: pubsub Issues related to the googleapis/python-pubsub API. label Mar 25, 2020
@pradn pradn mentioned this issue Mar 25, 2020
Merged
@pradn pradn changed the title The api-endpoint parameter was being ignored in both PublisherClient and SubscriberClient The client_options.api_endpoint parameter is being ignored in both PublisherClient and SubscriberClient Mar 25, 2020
@plamut plamut added priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Mar 25, 2020
gcf-merge-on-green bot pushed a commit that referenced this issue Mar 25, 2020
@pradn
fix: use client_options.api_endpoint parameter instead of ignoring it (…
56b8d7b 
…#59)

- The client_options.api-endpoint parameter was being ignored. This bug prevented users from using regional endpoints. It also made it harder to test code against nonprod endpoints.

Fixes #61
@release-please release-please bot mentioned this issue Aug 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yoshi-automation yoshi-automation

Labels
api: pubsub Issues related to the googleapis/python-pubsub API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: use client_options.api_endpoint parameter instead of ignoring it pradn/python-pubsub
3 participants
@pradn @plamut @yoshi-automation