Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use client_options.api_endpoint parameter instead of ignoring it #59

Merged
merged 3 commits into from Mar 25, 2020
Merged

fix: use client_options.api_endpoint parameter instead of ignoring it #59

merged 3 commits into from Mar 25, 2020

Conversation

pradn
Copy link
Contributor

@pradn pradn commented Mar 25, 2020 •
edited

  • The client_options.api-endpoint parameter was being ignored. This bug prevented users from using regional endpoints. It also made it harder to test code against nonprod endpoints.

Fixes #61

@pradn pradn requested a review from plamut March 25, 2020 01:47
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 25, 2020
plamut
plamut suggested changes Mar 25, 2020
View reviewed changes
Copy link
Contributor

@plamut plamut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested a few Improvements. Let's also open an issue for the fix so that we have it in the next release's changelog.

google/cloud/pubsub_v1/publisher/client.py Outdated Show resolved Hide resolved
plamut
plamut reviewed Mar 25, 2020
View reviewed changes
Copy link
Contributor

@plamut plamut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good, let's just cover the problematic edge case with an additional test.

tests/unit/pubsub_v1/publisher/test_publisher_client.py Show resolved Hide resolved
@pradn pradn added the automerge Merge the pull request once unit tests and other checks pass. label Mar 25, 2020
@pradn pradn changed the title fix: use api_endpoint parameter instead of ignoring it fix: use client_options.api_endpoint parameter instead of ignoring it Mar 25, 2020
@gcf-merge-on-green gcf-merge-on-green bot merged commit 56b8d7b into googleapis:master Mar 25, 2020
@pradn pradn deleted the fix_api_endpoint branch March 25, 2020 22:08
@release-please release-please bot mentioned this pull request Aug 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plamut plamut plamut approved these changes

Assignees
No one assigned
Labels
automerge Merge the pull request once unit tests and other checks pass. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The client_options.api_endpoint parameter is being ignored in both PublisherClient and SubscriberClient
3 participants
@pradn @plamut @googlebot