Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for 504 DeadlineExceeded for synchronous pull without published messages #52

Closed
plamut opened this issue Mar 23, 2020 · 0 comments · Fixed by #53
Closed

Add test for 504 DeadlineExceeded for synchronous pull without published messages #52

plamut opened this issue Mar 23, 2020 · 0 comments · Fixed by #53
Assignees
@plamut
Labels
api: pubsub Issues related to the googleapis/python-pubsub API. testing type: process A process-related concern. May include testing, release, or the like.

Comments

@plamut
Copy link
Contributor

plamut commented Mar 23, 2020

Related to #47 and the pull request that will fix it.

We should cover the fix with a system test to detect if a regression occurs again.
@plamut plamut added type: process A process-related concern. May include testing, release, or the like. testing labels Mar 23, 2020
@plamut plamut self-assigned this Mar 23, 2020
@product-auto-label product-auto-label bot added the api: pubsub Issues related to the googleapis/python-pubsub API. label Mar 23, 2020
@plamut plamut mentioned this issue Mar 23, 2020
Merged
4 tasks
@pradn pradn closed this as completed in #53 Mar 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@plamut plamut

Labels
api: pubsub Issues related to the googleapis/python-pubsub API. testing type: process A process-related concern. May include testing, release, or the like.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: cover the fix for sync pull with no messages plamut/python-pubsub
1 participant
@plamut