Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set default publisher retry and deadline settings to be consistent with desired values #494

Closed
plamut opened this issue Sep 3, 2021 · 1 comment · Fixed by #495
Closed
Assignees
Labels
api: pubsub Issues related to the googleapis/python-pubsub API. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: process A process-related concern. May include testing, release, or the like.

Comments

@plamut
Copy link
Contributor

plamut commented Sep 3, 2021

Similar to the java-pubsub PR, the current default retry and timeout settings for publisher methods should be adjusted.

The methods are wrapped in the base publisher transport. It's a generated part of the library, and the generator uses these settings.

It appears that the settings are consistent with the values shared in internal docs, except for the "total timeout", which is the retry deadline, i.e. "how long to keep retrying in seconds".

@plamut plamut added type: process A process-related concern. May include testing, release, or the like. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. labels Sep 3, 2021
@plamut plamut self-assigned this Sep 3, 2021
@product-auto-label product-auto-label bot added the api: pubsub Issues related to the googleapis/python-pubsub API. label Sep 3, 2021
@plamut
Copy link
Contributor Author

plamut commented Sep 3, 2021

It appears that in the generator template the same setting value (service.method) is used for the timeout and the retry deadline. We might be better off by just overriding the deadline with a replacement rule in the short term.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the googleapis/python-pubsub API. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: process A process-related concern. May include testing, release, or the like.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant