Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove dependency on pytz #472

Merged
merged 3 commits into from Aug 13, 2021
Merged

fix: remove dependency on pytz #472

merged 3 commits into from Aug 13, 2021

Conversation

busunkim96
Copy link
Contributor

@busunkim96 busunkim96 commented Aug 12, 2021

@busunkim96 busunkim96 requested review from a team as code owners August 12, 2021 19:10
@product-auto-label product-auto-label bot added the api: pubsub Issues related to the googleapis/python-pubsub API. label Aug 12, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 12, 2021
@plamut
Copy link
Contributor

plamut commented Aug 13, 2021

I resolved the merge conflict through the web, I think it should be fine now (no tooling at my disposal, will see what the CI checks say).

Copy link
Contributor

@plamut plamut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, no traces of pytz anymore, thanks for this!

@plamut plamut mentioned this pull request Aug 13, 2021
@plamut
Copy link
Contributor

plamut commented Aug 13, 2021

The Pub/Sub Lite samples check failure is external, i.e. not caused by this PR.

Update: It was a sample for the code that had not been released yet at the time, but now a new version of Pub/Sub Lite has been released. Re-running the checks.

@plamut plamut added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 13, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 13, 2021
@plamut plamut added automerge Merge the pull request once unit tests and other checks pass. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Aug 13, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 13, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit 972cc16 into master Aug 13, 2021
@gcf-merge-on-green gcf-merge-on-green bot deleted the remove-pytz branch August 13, 2021 06:58
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Aug 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the googleapis/python-pubsub API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing pytz dependency
3 participants