Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: explain that future.cancel() is non-blocking #420

Merged
merged 1 commit into from Jun 11, 2021
Merged

docs: explain that future.cancel() is non-blocking #420

merged 1 commit into from Jun 11, 2021

Conversation

plamut
Copy link
Contributor

@plamut plamut commented May 29, 2021

Fixes #419.

PR checklist:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@plamut plamut requested a review from a team as a code owner May 29, 2021 13:45
@product-auto-label product-auto-label bot added the api: pubsub Issues related to the googleapis/python-pubsub API. label May 29, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label May 29, 2021
@plamut plamut added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 30, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 30, 2021
@plamut plamut added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 31, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 31, 2021
@plamut plamut added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 31, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 31, 2021
@plamut plamut added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 31, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 31, 2021
@plamut plamut requested a review from pradn June 2, 2021 09:01
@plamut plamut merged commit c825789 into googleapis:master Jun 11, 2021
@plamut plamut deleted the iss-419 branch June 11, 2021 05:12
@release-please release-please bot mentioned this pull request Aug 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anguillanneuf anguillanneuf anguillanneuf approved these changes

@pradn pradn Awaiting requested review from pradn

Assignees
No one assigned
Labels
api: pubsub Issues related to the googleapis/python-pubsub API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The changed behavior of StreamingPullFuture.cancel() should be documented
3 participants
@plamut @anguillanneuf @yoshi-kokoro