Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: scheduler errors when executor in shutdown #399

Merged
merged 1 commit into from May 18, 2021
Merged

fix: scheduler errors when executor in shutdown #399

merged 1 commit into from May 18, 2021

Conversation

plamut
Copy link
Contributor

@plamut plamut commented Apr 27, 2021 •
edited

Fixes #394 (possibly).

This PR fixes uncaught exceptions in internal scheduler that can happen when the underlying executor is already being shut down (by another thread). It might not fix the reported hanging behavior, but it's a start.

PR checklist:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@plamut plamut requested a review from a team as a code owner April 27, 2021 14:50
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Apr 27, 2021
@product-auto-label product-auto-label bot added the api: pubsub Issues related to the googleapis/python-pubsub API. label Apr 27, 2021
@plamut plamut mentioned this pull request Apr 27, 2021
Closed
@plamut
Copy link
Contributor Author

plamut commented Apr 28, 2021

Stale CI checks.

@plamut plamut added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 28, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 28, 2021
@jimfulton jimfulton self-requested a review May 17, 2021 14:42
@plamut plamut merged commit 39a83d3 into googleapis:master May 18, 2021
@plamut plamut deleted the iss-394 branch May 18, 2021 11:38
gcf-merge-on-green bot pushed a commit that referenced this pull request May 18, 2021
@release-please
chore: release 2.5.0 (#412)
69f67f2 
🤖 I have created a release \*beep\* \*boop\*
---
## [2.5.0](https://www.github.com/googleapis/python-pubsub/compare/v2.4.2...v2.5.0) (2021-05-18)


### Features

* make publish futures compatible with concurrent.futures.as_completed() ([#397](https://www.github.com/googleapis/python-pubsub/issues/397)) ([e29a2c0](https://www.github.com/googleapis/python-pubsub/commit/e29a2c0ac6c5d2ebf2311646e552a02f184cfedc))


### Bug Fixes

* scheduler errors when executor in shutdown ([#399](https://www.github.com/googleapis/python-pubsub/issues/399)) ([39a83d3](https://www.github.com/googleapis/python-pubsub/commit/39a83d3eef196e88478ad8362201a2ab12e9f681))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
@release-please release-please bot mentioned this pull request Aug 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimfulton jimfulton jimfulton approved these changes

Assignees
No one assigned
Labels
api: pubsub Issues related to the googleapis/python-pubsub API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Streaming pull shutdown hangs indefinitely on error in callback
3 participants
@plamut @jimfulton @yoshi-kokoro