Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pubsub): implement max_duration_per_lease_extension option #38

Merged
merged 7 commits into from Mar 3, 2020

Conversation

IlyaFaer
Copy link

Closes #35

@IlyaFaer IlyaFaer added the type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. label Feb 26, 2020
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 26, 2020
@IlyaFaer IlyaFaer changed the title Max extension period feat(pubsub): implement max_extension_period Feb 26, 2020
Copy link
Author

@IlyaFaer IlyaFaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see few places, where pure percentile is still used:

stream_ack_deadline_seconds = self.ack_histogram.percentile(99)

requests.ModAckRequest(message.ack_id, self._ack_histogram.percentile(99))

My opinion, ack_deadline should be used there, but I'm not very sure

@IlyaFaer IlyaFaer marked this pull request as ready for review February 26, 2020 10:45
@pradn
Copy link
Contributor

pradn commented Feb 28, 2020

It looks pretty good, just a small comment.

Let's wait on merging this in until we have word on the final name for "max_extension_period".

@IlyaFaer IlyaFaer changed the title feat(pubsub): implement max_extension_period feat(pubsub): implement max_duration_per_lease_extension option Mar 2, 2020
@pradn pradn merged commit d911a2d into googleapis:master Mar 3, 2020
@IlyaFaer IlyaFaer deleted the max_extension_period branch May 28, 2020 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pubsub: expose a max_duration_per_lease_extension setting for subscribers
3 participants