New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pubsub): implement max_duration_per_lease_extension option #38
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see few places, where pure percentile is still used:
python-pubsub/google/cloud/pubsub_v1/subscriber/_protocol/streaming_pull_manager.py
Line 440 in 380cb38
stream_ack_deadline_seconds = self.ack_histogram.percentile(99) |
python-pubsub/google/cloud/pubsub_v1/subscriber/_protocol/streaming_pull_manager.py
Line 595 in 380cb38
requests.ModAckRequest(message.ack_id, self._ack_histogram.percentile(99)) |
My opinion, ack_deadline
should be used there, but I'm not very sure
google/cloud/pubsub_v1/subscriber/_protocol/streaming_pull_manager.py
Outdated
Show resolved
Hide resolved
It looks pretty good, just a small comment. Let's wait on merging this in until we have word on the final name for "max_extension_period". |
Closes #35