fix(sample): bump the max_time to 10 mins for a flaky test #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: pubsub
google-cla
bot
added
the
cla: yes
product-auto-label
bot
added
the
samples
|
We saw a test failure with 404 error with a dlq subscription. In my understanding, Pub/Sub returns 404 when the dlq subscription is not ready yet. I suspect that the dlq subscription was not yet ready after 5 mins from creation. Here I'm bumping the max_time to 10 mins. I have a question. What's the expected time for a dlq subscription becoming ready? I'd like to set the max_time at around 90 %tile latency with some retries. |
anguillanneuf
approved these changes
Mar 8, 2021
|
Let's merge this first and see how it goes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #291