New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(sample): mitigate flakiness in subscriber_test #304
Conversation
fixes googleapis#289 fixes googleapis#288 I think there were few problems with the tests. 1. google.api_core.exceptions.Unknown is not retried. 2. number of messages published in test_receive_synchronously_with_lease was 5, but the sample code is fetching 3 messages in bulk. 3. assertion in test_receive_synchronously_with_lease was too strict. 4. failure in subscriber_test was incorrectly considered a failure in teardown of quickstart_test. I hope these changes will mitigate the flakiness.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yah, with sync pull, we may not get the specified number of messages, so the test is too strict there.
Using unknown
is also better.
LGTM.
I LGTM'ed too early. Tests are still flaky (might have become flakier) |
@busunkim96 There is another instnace of |
@anguillanneuf PTAL |
fixes #289
fixes #288
I think there were few problems with the tests.
was 5, but the sample code is fetching 3 messages in bulk.
teardown of quickstart_test.
I hope these changes will mitigate the flakiness.