fix: SSL error when using the client with the emulator #297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
product-auto-label
bot
added
the
api: pubsub
plamut
changed the title
anguillanneuf
suggested changes
Feb 26, 2021
There was a problem hiding this comment.
I'm not sure what's wrong, but when trying your code against the emulator, I still got errors:
E0226 11:38:32.777295000 4749241856 ssl_transport_security.cc:1439] Handshake failed with fatal error SSL_ERROR_SSL: error:100000f7:SSL routines:OPENSSL_internal:WRONG_VERSION_NUMBER.
E0226 11:38:33.843773000 4749241856 ssl_transport_security.cc:1439] Handshake failed with fatal error SSL_ERROR_SSL: error:100000f7:SSL routines:OPENSSL_internal:WRONG_VERSION_NUMBER.
E0226 11:38:35.286951000 4749241856 ssl_transport_security.cc:1439] Handshake failed with fatal error SSL_ERROR_SSL: error:100000f7:SSL routines:OPENSSL_internal:WRONG_VERSION_NUMBER.
E0226 11:38:38.925703000 4749241856 ssl_transport_security.cc:1439] Handshake failed with fatal error SSL_ERROR_SSL: error:100000f7:SSL routines:OPENSSL_internal:WRONG_VERSION_NUMBER.
And the emulator complains about:
[pubsub] INFO: Unknown request URI: /bad-request
[pubsub] Feb 26, 2021 11:39:01 AM io.gapi.emulators.netty.HttpVersionRoutingHandler channelRead
[pubsub] INFO: Detected non-HTTP/2 connection.
[pubsub] Feb 26, 2021 11:39:01 AM io.gapi.emulators.netty.NotFoundHandler handleRequest
[pubsub] INFO: Unknown request URI: /bad-request
My gcloud SDK version is 329.0.0.
|
@anguillanneuf Strange, I cannot reproduce this, it works just fine (both with gcloud SDK 327.0.0 and yours 329.0.0). Can you double check that it's indeed the code from the PR branch that is run and that I'm trying to figure out if and where our test setups differ.... |
anguillanneuf
approved these changes
Mar 1, 2021
There was a problem hiding this comment.
@plamut Ah I'm so sorry. I created a branch of the name plamut-iss-290 but I never pulled in your code. Your fix is working for me.
globophobe
added a commit
to globophobe/cryptofeed
that referenced
this pull request
Mar 10, 2021
Fixed breaking changes introduced by gcloud-aio dependency. Note: Pinned google_cloud_pubsub~=2.2.0 in setup.py because of an SSL issue in the Pub/Sumb emulator. google_cloud_pubsub fix is merged, but not on pypi: googleapis/python-pubsub#297
globophobe
added a commit
to globophobe/cryptofeed
that referenced
this pull request
Mar 10, 2021
Fixed breaking changes introduced by gcloud-aio dependency. Closes bmoscon#433 Note: Pinned google_cloud_pubsub~=2.2.0 in setup.py because of an SSL issue in the Pub/Sumb emulator. google_cloud_pubsub fix is merged, but not on pypi: googleapis/python-pubsub#297
globophobe
added a commit
to globophobe/cryptofeed
that referenced
this pull request
Mar 10, 2021
Fixed breaking changes introduced by gcloud-aio dependency. Closes bmoscon#433 Note: Pinned google_cloud_pubsub~=2.2.0 in setup.py because of an SSL issue in the Pub/Sumb emulator. google_cloud_pubsub fix is merged, but not on pypi: googleapis/python-pubsub#297
2 tasks
bmoscon
pushed a commit
to bmoscon/cryptofeed
that referenced
this pull request
Mar 10, 2021
Fixed breaking changes introduced by gcloud-aio dependency. Closes #433 Note: Pinned google_cloud_pubsub~=2.2.0 in setup.py because of an SSL issue in the Pub/Sumb emulator. google_cloud_pubsub fix is merged, but not on pypi: googleapis/python-pubsub#297
This was referenced Apr 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #290.
This PR makes sure that insecure gRPC channel is used when running against the emulator. To verify the fix, run the code example as described in the issue description.
The PR also includes a lot of unrelated synth changes in the second commit, but that's because #258 and #267 could not be merged yet, the CLA status is stuck. If this PR is merged, we could even close the other two.
PR checklist: