Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Modify synth.py to update grpc transport options #266

Merged
merged 5 commits into from Dec 28, 2020

Conversation

dpcollins-google
Copy link
Contributor

@dpcollins-google dpcollins-google commented Dec 23, 2020

Includes manual changes and synth.py regeneration.

@dpcollins-google dpcollins-google requested a review from a team as a code owner December 23, 2020 19:32
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Dec 23, 2020
@product-auto-label product-auto-label bot added the api: pubsub Issues related to the googleapis/python-pubsub API. label Dec 23, 2020
@dpcollins-google dpcollins-google added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Dec 23, 2020
@busunkim96
Copy link
Contributor

I did a rebase on master, tweaked the regex, and ran synthtool. The diff has some unrelated file changes because there are template changes and a new proto.

@dpcollins-google dpcollins-google removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Dec 28, 2020
@dpcollins-google dpcollins-google changed the title fix: Modify synth.py to update grpc transport options. fix: Modify synth.py to update grpc transport options Dec 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the googleapis/python-pubsub API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants