Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: document potentially unexpected blocking behavior of publish() method #214

Merged
merged 4 commits into from Nov 10, 2020

Conversation

dpcollins-google
Copy link
Contributor

No description provided.

@dpcollins-google dpcollins-google requested a review from a team as a code owner September 30, 2020 13:52
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 30, 2020
Copy link
Contributor

@anguillanneuf anguillanneuf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We use conventional commits. Commit messages may not end with a period.

google/cloud/pubsub_v1/publisher/client.py Outdated Show resolved Hide resolved
@tseaver tseaver changed the title docs: Document potentially unexpected blocking behavior of publish() method docs: document potentially unexpected blocking behavior of publish() method Oct 15, 2020
@tseaver tseaver added the automerge Merge the pull request once unit tests and other checks pass. label Oct 15, 2020
@gcf-merge-on-green
Copy link

Your PR has attempted to merge for 3 hours. Please check that all required checks have passed, you have an automerge label, and that all your reviewers have approved the PR

1 similar comment
@gcf-merge-on-green
Copy link

Your PR has attempted to merge for 3 hours. Please check that all required checks have passed, you have an automerge label, and that all your reviewers have approved the PR

@anguillanneuf anguillanneuf self-requested a review October 15, 2020 21:04
@gcf-merge-on-green
Copy link

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, or one of your required reviews was not approved. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

1 similar comment
@gcf-merge-on-green
Copy link

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, or one of your required reviews was not approved. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed automerge Merge the pull request once unit tests and other checks pass. labels Oct 15, 2020
@pradn pradn self-requested a review October 30, 2020 23:46
@anguillanneuf anguillanneuf merged commit b6d9bd7 into master Nov 10, 2020
@anguillanneuf anguillanneuf deleted the dpcollins-google-patch-1 branch November 10, 2020 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants