Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix get topic_path in subscriber sample #210

Merged
merged 2 commits into from Sep 28, 2020
Merged

docs: fix get topic_path in subscriber sample #210

merged 2 commits into from Sep 28, 2020

Conversation

ryanyuan
Copy link
Contributor

@ryanyuan ryanyuan commented Sep 25, 2020 •
edited

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #209 🦕

@ryanyuan ryanyuan requested a review from a team as a code owner September 25, 2020 07:20
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 25, 2020
@product-auto-label product-auto-label bot added api: pubsub Issues related to the googleapis/python-pubsub API. samples Issues that are directly related to samples. labels Sep 25, 2020
marjohkan
marjohkan reviewed Sep 25, 2020
View reviewed changes
Copy link

@marjohkan marjohkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you meaning to create an instance of pubsub.SubscriberClient and name the variable "publisher"?
Line 40:
# publisher = pubsub.SubscriberClient()

@ryanyuan ryanyuan force-pushed the fix/subscriber-get-topic-path-docs branch from e2877a5 to 7e45f19 Compare September 25, 2020 22:57
@ryanyuan
Copy link
Contributor Author

@marjohkan It should be 'publisher = pubsub.PublisherClient()'. My bad, copy/paste error.

@ryanyuan ryanyuan removed the request for review from a team September 25, 2020 22:58
@ryanyuan
Copy link
Contributor Author

@plamut I just accidentally removed googleapis/api-pubsub from reviewers.

plamut
plamut approved these changes Sep 28, 2020
View reviewed changes
Copy link
Contributor

@plamut plamut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for catching and fixing this!

@plamut plamut added kokoro:force-run Add this label to force Kokoro to re-run the tests. automerge Merge the pull request once unit tests and other checks pass. labels Sep 28, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 28, 2020
@plamut
Copy link
Contributor

plamut commented Sep 28, 2020

"Stream removed" flakiness caused the Python3.7 samples check to fail.

@plamut plamut added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 28, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 28, 2020
@plamut plamut merged commit 7228f6c into googleapis:master Sep 28, 2020
@release-please release-please bot mentioned this pull request Aug 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marjohkan marjohkan marjohkan left review comments

@plamut plamut plamut approved these changes

Assignees
No one assigned
Labels
api: pubsub Issues related to the googleapis/python-pubsub API. automerge Merge the pull request once unit tests and other checks pass. cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SubscriberClient no longer has 'topic_path' method, but documentation still makes references to it.
4 participants
@ryanyuan @plamut @marjohkan @yoshi-kokoro