Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: explain how to nack a sync pull message #123

Merged
merged 2 commits into from Jun 18, 2020
Merged

docs: explain how to nack a sync pull message #123

merged 2 commits into from Jun 18, 2020

Conversation

plamut
Copy link
Contributor

@plamut plamut commented Jun 15, 2020

Closes #122.

This PR adds a short explanation on how to NACK sync pull messages.

PR checklist

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@plamut plamut added the type: docs Improvement to the documentation for an API. label Jun 15, 2020
@plamut plamut requested a review from pradn June 15, 2020 14:17
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 15, 2020
pradn
pradn approved these changes Jun 17, 2020
View reviewed changes
docs/subscriber/index.rst Outdated Show resolved Hide resolved
docs/subscriber/index.rst Outdated Show resolved Hide resolved
@plamut plamut requested a review from pradn June 18, 2020 17:40
@pradn pradn merged commit f2eec65 into googleapis:master Jun 18, 2020
@plamut plamut deleted the iss-122 branch June 19, 2020 06:49
sethmaxwl pushed a commit to sethmaxwl/python-pubsub that referenced this pull request Jul 9, 2020
@plamut @sethmaxwl
docs: explain how to nack a sync pull message (googleapis#123)
c78f6c4
@release-please release-please bot mentioned this pull request Aug 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pradn pradn pradn approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement. type: docs Improvement to the documentation for an API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document how to nack synchronous pull messages
3 participants
@plamut @pradn @googlebot