Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
docs: Add a link to Pub/Sub filtering language public documentation t…
…o pubsub.proto (#121)

* docs: Add a link to Pub/Sub filtering language public documentation to pubsub.proto

PiperOrigin-RevId: 315930680

Source-Author: Google APIs <noreply@google.com>
Source-Date: Thu Jun 11 10:43:34 2020 -0700
Source-Repo: googleapis/googleapis
Source-Sha: a19b46e54cc5195557f70ff68f1696d1e3b4702e
Source-Link: googleapis/googleapis@a19b46e

* fix: use protoc-docs-plugin 0.8.0

Fixes issue with missing newline before 'Attributes' in Python docstrings.

PiperOrigin-RevId: 316182409

Source-Author: Google APIs <noreply@google.com>
Source-Date: Fri Jun 12 14:52:11 2020 -0700
Source-Repo: googleapis/googleapis
Source-Sha: 184661793fbe3b89f2b485c303e7466cef9d21a1
Source-Link: googleapis/googleapis@1846617

* feature: Add flow control settings for StreamingPullRequest to pubsub.proto

PiperOrigin-RevId: 317914250

Source-Author: Google APIs <noreply@google.com>
Source-Date: Tue Jun 23 12:05:24 2020 -0700
Source-Repo: googleapis/googleapis
Source-Sha: 14f0c2cc9392234707247ab2b0782c118cb179aa
Source-Link: googleapis/googleapis@14f0c2c

* chore: update grpc to v1.30.0

PiperOrigin-RevId: 317949519

Source-Author: Google APIs <noreply@google.com>
Source-Date: Tue Jun 23 15:22:22 2020 -0700
Source-Repo: googleapis/googleapis
Source-Sha: 7157f9552747421572cf1ab3aec1105c05ebd4f9
Source-Link: googleapis/googleapis@7157f95

* Updates to build Google Ads API build files.

PiperOrigin-RevId: 318028816

Source-Author: Google APIs <noreply@google.com>
Source-Date: Wed Jun 24 02:32:38 2020 -0700
Source-Repo: googleapis/googleapis
Source-Sha: b882b8e6bfcd708042ff00f7adc67ce750817dd0
Source-Link: googleapis/googleapis@b882b8e

Co-authored-by: Prad Nelluru <pradn@google.com>
  • Loading branch information
yoshi-automation and pradn committed Jul 6, 2020
1 parent cfe486a commit 8802d81
Show file tree
Hide file tree
Showing 5 changed files with 999 additions and 178 deletions.
3 changes: 2 additions & 1 deletion google/cloud/pubsub_v1/gapic/subscriber_client.py
Expand Up @@ -346,7 +346,8 @@ def create_subscription(
If a dict is provided, it must be of the same form as the protobuf
message :class:`~google.cloud.pubsub_v1.types.ExpirationPolicy`
filter_ (str): An expression written in the Cloud Pub/Sub filter language. If
filter_ (str): An expression written in the Pub/Sub `filter
language <https://cloud.google.com/pubsub/docs/filtering>`__. If
non-empty, then only ``PubsubMessage``\ s whose ``attributes`` field
matches the filter are delivered on this subscription. If empty, then no
messages are filtered out.
Expand Down
28 changes: 26 additions & 2 deletions google/cloud/pubsub_v1/proto/pubsub.proto
Expand Up @@ -191,7 +191,8 @@ message PubsubMessage {
bytes data = 1;

// Attributes for this message. If this field is empty, the message must
// contain non-empty data.
// contain non-empty data. This can be used to filter messages on the
// subscription.
map<string, string> attributes = 2;

// ID of this message, assigned by the server when the message is published.
Expand Down Expand Up @@ -700,7 +701,8 @@ message Subscription {
// value for `expiration_policy.ttl` is 1 day.
ExpirationPolicy expiration_policy = 11;

// An expression written in the Cloud Pub/Sub filter language. If non-empty,
// An expression written in the Pub/Sub [filter
// language](https://cloud.google.com/pubsub/docs/filtering). If non-empty,
// then only `PubsubMessage`s whose `attributes` field matches the filter are
// delivered on this subscription. If empty, then no messages are filtered
// out.
Expand Down Expand Up @@ -1107,6 +1109,28 @@ message StreamingPullRequest {
// transferred to the new stream. The same client_id should not be used for
// different client instances.
string client_id = 6;

// Flow control settings for the maximum number of outstanding messages. When
// there are `max_outstanding_messages` or more currently sent to the
// streaming pull client that have not yet been acked or nacked, the server
// stops sending more messages. The sending of messages resumes once the
// number of outstanding messages is less than this value. If the value is
// <= 0, there is no limit to the number of outstanding messages. This
// property can only be set on the initial StreamingPullRequest. If it is set
// on a subsequent request, the stream will be aborted with status
// `INVALID_ARGUMENT`.
int64 max_outstanding_messages = 7;

// Flow control settings for the maximum number of outstanding bytes. When
// there are `max_outstanding_bytes` or more worth of messages currently sent
// to the streaming pull client that have not yet been acked or nacked, the
// server will stop sending more messages. The sending of messages resumes
// once the number of outstanding bytes is less than this value. If the value
// is <= 0, there is no limit to the number of outstanding bytes. This
// property can only be set on the initial StreamingPullRequest. If it is set
// on a subsequent request, the stream will be aborted with status
// `INVALID_ARGUMENT`.
int64 max_outstanding_bytes = 8;
}

// Response for the `StreamingPull` method. This response is used to stream
Expand Down
165 changes: 135 additions & 30 deletions google/cloud/pubsub_v1/proto/pubsub_pb2.py

Large diffs are not rendered by default.

0 comments on commit 8802d81

Please sign in to comment.