Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(sample): mitigate flakiness in subscriber_test (#304)
* fix(sample): mitigate flakiness in subscriber_test fixes #289 fixes #288 I think there were few problems with the tests. 1. google.api_core.exceptions.Unknown is not retried. 2. number of messages published in test_receive_synchronously_with_lease was 5, but the sample code is fetching 3 messages in bulk. 3. assertion in test_receive_synchronously_with_lease was too strict. 4. failure in subscriber_test was incorrectly considered a failure in teardown of quickstart_test. I hope these changes will mitigate the flakiness. * lint * also retry NotFound for dlq subscription * lint * ignore NotFound on deletion * lint
- Loading branch information
Takashi Matsuo
committed
Mar 2, 2021
1 parent
bfe37dd
commit 271a385
Showing
1 changed file
with
38 additions
and
18 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters