From f4f810ddc58b4ebe076457d6d1ba75d023fce572 Mon Sep 17 00:00:00 2001 From: "gcf-owl-bot[bot]" <78513119+gcf-owl-bot[bot]@users.noreply.github.com> Date: Fri, 2 Jul 2021 14:50:25 +0000 Subject: [PATCH] fix: disable always_use_jwt_access (#39) fix: disable always_use_jwt_access Committer: @busunkim96 PiperOrigin-RevId: 382142900 Source-Link: https://github.com/googleapis/googleapis/commit/513440fda515f3c799c22a30e3906dcda325004e Source-Link: https://github.com/googleapis/googleapis-gen/commit/7b1e2c31233f79a704ec21ca410bf661d6bc68d0 --- .../services/iam_checker/transports/base.py | 2 +- .../services/iam_checker/transports/grpc.py | 5 +++- .../iam_checker/transports/grpc_asyncio.py | 5 +++- .../test_iam_checker.py | 26 ++++++++++++++++--- 4 files changed, 31 insertions(+), 7 deletions(-) diff --git a/google/cloud/policytroubleshooter_v1/services/iam_checker/transports/base.py b/google/cloud/policytroubleshooter_v1/services/iam_checker/transports/base.py index ed922de..87cecfb 100644 --- a/google/cloud/policytroubleshooter_v1/services/iam_checker/transports/base.py +++ b/google/cloud/policytroubleshooter_v1/services/iam_checker/transports/base.py @@ -98,7 +98,7 @@ def __init__( scopes_kwargs = self._get_scopes_kwargs(self._host, scopes) # Save the scopes. - self._scopes = scopes or self.AUTH_SCOPES + self._scopes = scopes # If no credentials are provided, then determine the appropriate # defaults. diff --git a/google/cloud/policytroubleshooter_v1/services/iam_checker/transports/grpc.py b/google/cloud/policytroubleshooter_v1/services/iam_checker/transports/grpc.py index 74769be..37ba090 100644 --- a/google/cloud/policytroubleshooter_v1/services/iam_checker/transports/grpc.py +++ b/google/cloud/policytroubleshooter_v1/services/iam_checker/transports/grpc.py @@ -59,6 +59,7 @@ def __init__( client_cert_source_for_mtls: Callable[[], Tuple[bytes, bytes]] = None, quota_project_id: Optional[str] = None, client_info: gapic_v1.client_info.ClientInfo = DEFAULT_CLIENT_INFO, + always_use_jwt_access: Optional[bool] = False, ) -> None: """Instantiate the transport. @@ -99,6 +100,8 @@ def __init__( API requests. If ``None``, then default info will be used. Generally, you only need to set this if you're developing your own client library. + always_use_jwt_access (Optional[bool]): Whether self signed JWT should + be used for service account credentials. Raises: google.auth.exceptions.MutualTLSChannelError: If mutual TLS transport @@ -151,7 +154,7 @@ def __init__( scopes=scopes, quota_project_id=quota_project_id, client_info=client_info, - always_use_jwt_access=True, + always_use_jwt_access=always_use_jwt_access, ) if not self._grpc_channel: diff --git a/google/cloud/policytroubleshooter_v1/services/iam_checker/transports/grpc_asyncio.py b/google/cloud/policytroubleshooter_v1/services/iam_checker/transports/grpc_asyncio.py index 718cb78..63784dc 100644 --- a/google/cloud/policytroubleshooter_v1/services/iam_checker/transports/grpc_asyncio.py +++ b/google/cloud/policytroubleshooter_v1/services/iam_checker/transports/grpc_asyncio.py @@ -105,6 +105,7 @@ def __init__( client_cert_source_for_mtls: Callable[[], Tuple[bytes, bytes]] = None, quota_project_id=None, client_info: gapic_v1.client_info.ClientInfo = DEFAULT_CLIENT_INFO, + always_use_jwt_access: Optional[bool] = False, ) -> None: """Instantiate the transport. @@ -146,6 +147,8 @@ def __init__( API requests. If ``None``, then default info will be used. Generally, you only need to set this if you're developing your own client library. + always_use_jwt_access (Optional[bool]): Whether self signed JWT should + be used for service account credentials. Raises: google.auth.exceptions.MutualTlsChannelError: If mutual TLS transport @@ -197,7 +200,7 @@ def __init__( scopes=scopes, quota_project_id=quota_project_id, client_info=client_info, - always_use_jwt_access=True, + always_use_jwt_access=always_use_jwt_access, ) if not self._grpc_channel: diff --git a/tests/unit/gapic/policytroubleshooter_v1/test_iam_checker.py b/tests/unit/gapic/policytroubleshooter_v1/test_iam_checker.py index e732829..af55ca2 100644 --- a/tests/unit/gapic/policytroubleshooter_v1/test_iam_checker.py +++ b/tests/unit/gapic/policytroubleshooter_v1/test_iam_checker.py @@ -122,7 +122,25 @@ def test_iam_checker_client_service_account_always_use_jwt(client_class): ) as use_jwt: creds = service_account.Credentials(None, None, None) client = client_class(credentials=creds) - use_jwt.assert_called_with(True) + use_jwt.assert_not_called() + + +@pytest.mark.parametrize( + "transport_class,transport_name", + [ + (transports.IamCheckerGrpcTransport, "grpc"), + (transports.IamCheckerGrpcAsyncIOTransport, "grpc_asyncio"), + ], +) +def test_iam_checker_client_service_account_always_use_jwt_true( + transport_class, transport_name +): + with mock.patch.object( + service_account.Credentials, "with_always_use_jwt_access", create=True + ) as use_jwt: + creds = service_account.Credentials(None, None, None) + transport = transport_class(credentials=creds, always_use_jwt_access=True) + use_jwt.assert_called_once_with(True) @pytest.mark.parametrize("client_class", [IamCheckerClient, IamCheckerAsyncClient,]) @@ -814,7 +832,7 @@ def test_iam_checker_grpc_transport_client_cert_source_for_mtls(transport_class) "squid.clam.whelk:443", credentials=cred, credentials_file=None, - scopes=("https://www.googleapis.com/auth/cloud-platform",), + scopes=None, ssl_credentials=mock_ssl_channel_creds, quota_project_id=None, options=[ @@ -918,7 +936,7 @@ def test_iam_checker_transport_channel_mtls_with_client_cert_source(transport_cl "mtls.squid.clam.whelk:443", credentials=cred, credentials_file=None, - scopes=("https://www.googleapis.com/auth/cloud-platform",), + scopes=None, ssl_credentials=mock_ssl_cred, quota_project_id=None, options=[ @@ -962,7 +980,7 @@ def test_iam_checker_transport_channel_mtls_with_adc(transport_class): "mtls.squid.clam.whelk:443", credentials=mock_cred, credentials_file=None, - scopes=("https://www.googleapis.com/auth/cloud-platform",), + scopes=None, ssl_credentials=mock_ssl_cred, quota_project_id=None, options=[