Skip to content
This repository has been archived by the owner on Dec 31, 2023. It is now read-only.

feat!: move to microgen #33

Merged
merged 3 commits into from Sep 30, 2020
Merged

feat!: move to microgen #33

merged 3 commits into from Sep 30, 2020

Conversation

arithmetic1728
Copy link
Contributor

No description provided.

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 30, 2020
@arithmetic1728 arithmetic1728 marked this pull request as ready for review September 30, 2020 07:33
@arithmetic1728 arithmetic1728 requested review from a team as code owners September 30, 2020 07:33
@product-auto-label product-auto-label bot added the api: oslogin Issues related to the googleapis/python-oslogin API. label Sep 30, 2020
software-dov
software-dov approved these changes Sep 30, 2020
View reviewed changes
Copy link

@software-dov software-dov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a few questions.

synth.py Outdated Show resolved Hide resolved
synth.py Outdated Show resolved Hide resolved
busunkim96
busunkim96 approved these changes Sep 30, 2020
View reviewed changes
Copy link
Contributor

@busunkim96 busunkim96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one question about docs for common

synth.py Show resolved Hide resolved
@arithmetic1728 arithmetic1728 merged commit 97de222 into master Sep 30, 2020
@release-please release-please bot mentioned this pull request Sep 30, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@software-dov software-dov software-dov approved these changes

@busunkim96 busunkim96 busunkim96 approved these changes

@dinagraves dinagraves Awaiting requested review from dinagraves

Assignees
No one assigned
Labels
api: oslogin Issues related to the googleapis/python-oslogin API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@arithmetic1728 @software-dov @busunkim96