feat: add "not equal" support to the query filter #11
Conversation
0842346
to
ab5dddd
Compare
Rebased off the latest master. Can someone help take a look at this one. Should be fairly straight forward. |
Can someone help with this PR? |
@qingling128 Apologies, I didn't see this until now. Is there a way to do the filter by using the generated code directly? https://github.com/googleapis/python-monitoring/tree/e4bc5682d39f7e5938868497496f5d49318cee43/google/cloud/monitoring_v3/proto It looks like this client was originally handwritten and |
Hi @busunkim96 , We are currently trying to use the library in the following way:
Could you elaborate a bit on the suggestion to |
@busunkim96 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added the documentation link as suggested and rebased from upstream master.
Your PR has attempted to merge for 3 hours. Please check that all required checks have passed, you have an automerge label, and that all your reviewers have approved the PR |
1 similar comment
Your PR has attempted to merge for 3 hours. Please check that all required checks have passed, you have an automerge label, and that all your reviewers have approved the PR |
Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, or one of your required reviews was not approved. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot. |
@busunkim96 - Any chance you know why Kokoro is stuck in the |
@qingling128 Kokoro doesn't run automatically for people who do not belong to the GitHub 'googleapis' org. |
@busunkim96 - Thanks for the help to trigger the Kokoro test. The test seems to be failing for a bunch of documentation format check failures that predates this PR. Any suggestion for what I should do with them? https://source.cloud.google.com/results/invocations/fd68debc-462a-4dd6-b8f3-71c59cf5c1e8/log |
Ah, you can ignore the |
@busunkim96 - Thanks! Kokoro build passed. The docs-presubmit still blocks merging though. How can we skip that check? |
Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, or one of your required reviews was not approved. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot. |
@busunkim96 - Can we force submit this one and bypass the docs-presubmit failure? |
Thanks! |
BTW, do we have any scheduled release coming? |
@qingling128 I merged the release PR so it should be out to PyPI in the next 15 or so minutes. #48 |
Wow. That's so fast. Thank you so much! |
Fixes #10
Added unit tests.