Skip to content
This repository has been archived by the owner on Dec 31, 2023. It is now read-only.

Add "not equal" support to the query filter. #10

Closed
qingling128 opened this issue Apr 13, 2020 · 1 comment · Fixed by #11
Closed

Add "not equal" support to the query filter. #10

qingling128 opened this issue Apr 13, 2020 · 1 comment · Fixed by #11
Assignees
@busunkim96
Labels
api: monitoring Issues related to the googleapis/python-monitoring API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@qingling128
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Right now we can not filter query by something like metric.label.response_code != 200

Describe the solution you'd like
Add "not equal" support to the query filter.

Describe alternatives you've considered
I can't find alternative to this.
@product-auto-label product-auto-label bot added the api: monitoring Issues related to the googleapis/python-monitoring API. label Apr 13, 2020
@qingling128 qingling128 mentioned this issue Apr 13, 2020
Merged
@yoshi-automation yoshi-automation added the triage me I really want to be triaged. label Apr 14, 2020
@busunkim96 busunkim96 added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. and removed triage me I really want to be triaged. labels Apr 14, 2020
@qingling128
Copy link
Contributor Author

Hi, I've sent a PR (#11) to try support this and added the related unit tests. Seems like I can not request reviewers on the PR though. Does anyone know what I need to do to actually send it for review?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@busunkim96 busunkim96

Labels
api: monitoring Issues related to the googleapis/python-monitoring API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add "not equal" support to the query filter qingling128/python-monitoring
3 participants
@qingling128 @busunkim96 @yoshi-automation