Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up docs/snippets.py file #93

Closed
busunkim96 opened this issue Nov 11, 2020 · 1 comment
Closed

Clean up docs/snippets.py file #93

busunkim96 opened this issue Nov 11, 2020 · 1 comment
Assignees
@daniel-sanche
Labels
api: logging Issues related to the googleapis/python-logging API. type: cleanup An internal cleanup or hygiene concern.

Comments

@busunkim96
Copy link
Contributor

This file should be moved into the samples directory samples/snippets or removed entirely. It is used to add code to usage.rst but is not tested at the moment.

https://cloud.google.com/logging/docs/samples
@busunkim96 busunkim96 added the type: cleanup An internal cleanup or hygiene concern. label Nov 11, 2020
@product-auto-label product-auto-label bot added the api: logging Issues related to the googleapis/python-logging API. label Nov 11, 2020
@daniel-sanche
Copy link
Contributor

This was addressed in #140. The snippets have been moved to samples/snippets/usage_guide.py tests have been added

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@daniel-sanche daniel-sanche

Labels
api: logging Issues related to the googleapis/python-logging API. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@daniel-sanche @busunkim96