Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for generated samples #807

Open
gkevinzheng opened this issue Oct 31, 2023 · 0 comments
Open

Add tests for generated samples #807

gkevinzheng opened this issue Oct 31, 2023 · 0 comments
Assignees
Labels
api: logging Issues related to the googleapis/python-logging API. priority: p3 Desirable enhancement or fix. May not be included in next release. samples Issues that are directly related to samples. type: cleanup An internal cleanup or hygiene concern.

Comments

@gkevinzheng
Copy link
Contributor

          One thought: these generated samples aren't covered by tests. Have you considered adding tests for these to catch this kind of issue in the future, like the [other snippets](https://github.com/googleapis/python-logging/tree/c201482c913b5f2eac82359787511a5a92fc3406/samples/snippets)? Smoke tests could be helpful here (i.e. just executing each function and making sure nothing crashes)

There may be a simple way to programmatically load and execute each sample, but if it's bit more complicated we could open a bug for later

Originally posted by @daniel-sanche in #804 (comment)

@gkevinzheng gkevinzheng self-assigned this Oct 31, 2023
@product-auto-label product-auto-label bot added api: logging Issues related to the googleapis/python-logging API. samples Issues that are directly related to samples. labels Oct 31, 2023
@gkevinzheng gkevinzheng added priority: p3 Desirable enhancement or fix. May not be included in next release. type: cleanup An internal cleanup or hygiene concern. labels Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: logging Issues related to the googleapis/python-logging API. priority: p3 Desirable enhancement or fix. May not be included in next release. samples Issues that are directly related to samples. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Development

No branches or pull requests

1 participant