Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor tests #682

Open
daniel-sanche opened this issue Dec 5, 2022 · 0 comments
Open

refactor tests #682

daniel-sanche opened this issue Dec 5, 2022 · 0 comments
Labels
2023-triage api: logging Issues related to the googleapis/python-logging API. priority: p3 Desirable enhancement or fix. May not be included in next release. type: process A process-related concern. May include testing, release, or the like.

Comments

@daniel-sanche
Copy link
Contributor

There is a lot of duplicated logic in the test classes. It might be beneficial to do a refacor/rewrite at some point to clean up the codebase
@daniel-sanche daniel-sanche added type: process A process-related concern. May include testing, release, or the like. priority: p3 Desirable enhancement or fix. May not be included in next release. labels Dec 5, 2022
@product-auto-label product-auto-label bot added the api: logging Issues related to the googleapis/python-logging API. label Dec 5, 2022
@losalex losalex assigned daniel-sanche and unassigned losalex Dec 8, 2022
@daniel-sanche daniel-sanche removed their assignment Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
2023-triage api: logging Issues related to the googleapis/python-logging API. priority: p3 Desirable enhancement or fix. May not be included in next release. type: process A process-related concern. May include testing, release, or the like.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@daniel-sanche @losalex