New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update system test PubSub calls or change PubSub deps #64
Comments
Looks like it will be fixed in #62 |
Looks like tests are still broken, re-opening. |
The primary reason that the PubSub version update is breaking tests is that in google-cloud-pubsub<2.0.0, parameters required by the API were positional parameters (like The change is best exemplified like so: Before: from google.cloud import pubsub
publisher = pubsub.PublisherClient()
project_path = "projects/{}".format(PROJECT_ID)
topics = publisher.list_topics(project_path) After: from google.cloud import pubsub
publisher = pubsub.PublisherClient()
project_path = f"projects/{PROJECT_ID}"
topics = publisher.list_topics(request={"project": project_path}) There are two ways to resolve this:
OR
|
This was fixed in #70 |
The recent test failures have to do with a PubSub version update.
The broken method calls can be updated according to link, or the dependencies can be change like in python-storage (PR and possibly PR).
The text was updated successfully, but these errors were encountered: