Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cloud Logging lib should auto-detect running on Cloud Run #57

Closed
simonz130 opened this issue Jul 30, 2020 · 0 comments · Fixed by #200
Closed

Cloud Logging lib should auto-detect running on Cloud Run #57

simonz130 opened this issue Jul 30, 2020 · 0 comments · Fixed by #200
Assignees
@daniel-sanche
Labels
api: logging Issues related to the googleapis/python-logging API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Milestone
v2 Update 1

Comments

@simonz130
Copy link

Is your feature request related to a problem? Please describe.
When invoking Cloud Logging library on GCP, it should autodetect the resource on which it's running, such as GKE, GCE, etc. It doesn't do so for Cloud Run yet.
@simonz130 simonz130 added api: logging Issues related to the googleapis/python-logging API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Jul 30, 2020
@daniel-sanche daniel-sanche added this to the v2.4.0 milestone Jan 27, 2021
@daniel-sanche daniel-sanche linked a pull request Mar 2, 2021 that will close this issue
feat: detect monitored resources on all GCP environments #200
Merged
@daniel-sanche daniel-sanche mentioned this issue Mar 2, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@daniel-sanche daniel-sanche

Labels
api: logging Issues related to the googleapis/python-logging API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
v2 Update 1
Development

Successfully merging a pull request may close this issue.

feat: detect monitored resources on all GCP environments googleapis/python-logging
2 participants
@daniel-sanche @simonz130