Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: remove Python 2.7 support and change descriptions on virtual environment #47

Closed
ymotongpoo opened this issue Jun 29, 2020 · 0 comments · Fixed by #48
Closed

Docs: remove Python 2.7 support and change descriptions on virtual environment #47

ymotongpoo opened this issue Jun 29, 2020 · 0 comments · Fixed by #48
Assignees
@yoshi-automation
Labels
api: logging Issues related to the googleapis/python-logging API. triage me I really want to be triaged.

Comments

@ymotongpoo
Copy link
Contributor

Environment details

  • OS type and version: any
  • Python version: any
  • pip version: any
  • google-cloud-logging version: any

Steps to reproduce

  1. Read Installation section of README.rst
  2. Find the step to install virtualenv

Code example

Given Python 2.7 support is removed in January 1, 2020 and the oldest supported version is Python 3.5, we can expect that all environments are with venv that is included in the standard modules and is alternative of virtualenv in this use case. So we can replace the installation documents with the following descriptions:

  • macOS/Linux
python -m venv <your-env>
source <your-env>/bin/activate
<your-env>/bin/pip install google-cloud-logging
  • Windows
python -m venv <your-env>
<your-env>\Scripts\activate
<your-env>\Scripts\pip.exe install google-cloud-logging

Stack trace

N/A
@product-auto-label product-auto-label bot added the api: logging Issues related to the googleapis/python-logging API. label Jun 29, 2020
@ymotongpoo ymotongpoo mentioned this issue Jun 29, 2020
Merged
4 tasks
@yoshi-automation yoshi-automation added the triage me I really want to be triaged. label Jun 29, 2020
gcf-merge-on-green bot pushed a commit that referenced this issue Jul 1, 2020
@ymotongpoo
docs: change descriptions for virtual environment (#48)
c5c3c15 
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
- [X] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/python-logging/issues/new/choose) before writing your code!  That way we can discuss the change, evaluate designs, and agree on the general idea
- [X] Ensure the tests and linter pass
- [X] Code coverage does not decrease (if any source code was changed)
- [X] Appropriate docs were updated (if necessary)

Fixes #47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yoshi-automation yoshi-automation

Labels
api: logging Issues related to the googleapis/python-logging API. triage me I really want to be triaged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs: change descriptions for virtual environment ymotongpoo/python-logging
2 participants
@ymotongpoo @yoshi-automation