Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getting started sample shows how to iterate over empty logs list #44

Closed
simonz130 opened this issue Jun 25, 2020 · 0 comments · Fixed by #46
Closed

getting started sample shows how to iterate over empty logs list #44

simonz130 opened this issue Jun 25, 2020 · 0 comments · Fixed by #46
Assignees
@simonz130
Labels
api: logging Issues related to the googleapis/python-logging API. priority: p2 Moderately-important priority. Fix may not be included in next release.

Comments

@simonz130
Copy link

No description provided.

@simonz130 simonz130 self-assigned this Jun 25, 2020
@product-auto-label product-auto-label bot added the api: logging Issues related to the googleapis/python-logging API. label Jun 25, 2020
@yoshi-automation yoshi-automation added the triage me I really want to be triaged. label Jun 26, 2020
@ymotongpoo ymotongpoo mentioned this issue Jun 29, 2020
Merged
4 tasks
@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label Jun 30, 2020
@simonz130 simonz130 added the priority: p2 Moderately-important priority. Fix may not be included in next release. label Jul 1, 2020
@yoshi-automation yoshi-automation removed triage me I really want to be triaged. 🚨 This issue needs some love. labels Jul 1, 2020
gcf-merge-on-green bot pushed a commit that referenced this issue Jul 1, 2020
@ymotongpoo
docs: add initialization of LogEntry instance in the v2 example (#46)
251ac93 
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
- [X] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/python-logging/issues/new/choose) before writing your code!  That way we can discuss the change, evaluate designs, and agree on the general idea
- [X] Ensure the tests and linter pass
- [X] Code coverage does not decrease (if any source code was changed)
- [X] Appropriate docs were updated (if necessary)

Fixes #44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simonz130 simonz130

Labels
api: logging Issues related to the googleapis/python-logging API. priority: p2 Moderately-important priority. Fix may not be included in next release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs: add initialization of LogEntry instance in the v2 example ymotongpoo/python-logging
2 participants
@simonz130 @yoshi-automation