Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove noisy logs #290

Merged
merged 6 commits into from May 11, 2021
Merged

fix: remove noisy logs #290

merged 6 commits into from May 11, 2021

Conversation

daniel-sanche
Copy link
Contributor

  • Adds "google.api_core.bidi" and "werkzeug" to the list of excluded logs to fix some noisyness on some environments
  • Previously, SteamHandlers were added to excluded loggers by default, so they would still log to standard output. This is leading to noisy logs on environments that send all stdout to Cloud Logging. Instead, users should expect to add handlers manually if desired

Fixes #261

@daniel-sanche daniel-sanche self-assigned this May 10, 2021
@daniel-sanche daniel-sanche requested review from a team as code owners May 10, 2021 19:00
@product-auto-label product-auto-label bot added the api: logging Issues related to the googleapis/python-logging API. label May 10, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label May 10, 2021
simonz130
simonz130 approved these changes May 10, 2021
View reviewed changes
google/cloud/logging_v2/handlers/handlers.py Outdated Show resolved Hide resolved
@daniel-sanche daniel-sanche merged commit fe08351 into v2_update_2 May 11, 2021
@daniel-sanche daniel-sanche deleted the remove-noise branch May 11, 2021 21:11
daniel-sanche added a commit that referenced this pull request May 12, 2021
@daniel-sanche
fix: remove noisy logs (#290)
bdf8273
@daniel-sanche daniel-sanche mentioned this pull request May 12, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonz130 simonz130 simonz130 approved these changes

Assignees

@daniel-sanche daniel-sanche

Labels
api: logging Issues related to the googleapis/python-logging API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@daniel-sanche @simonz130