feat: record source locations #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: logging
google-cla
bot
added
the
cla: yes
0xSage
approved these changes
Apr 8, 2021
simonz130
approved these changes
Apr 9, 2021
| user_labels = getattr(record, "labels", {}) | ||
| # merge labels | ||
| total_labels = self.labels if self.labels is not None else {} | ||
| total_labels.update(user_labels) | ||
| if len(total_labels) == 0: | ||
| total_labels = None | ||
| # create source location object | ||
| if record.lineno and record.funcName and record.pathname: |
There was a problem hiding this comment.
Can some of the 3 be empty? For example, code that's not part of any function.
There was a problem hiding this comment.
No, these are all part of the official record object spec, so the attributes will all exist.
They could be None, but that would be caught by this check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
environments using the new CloudLoggingFilter will now capture source locations when sending logs to GCP
This feature will currently not work in GAE and GKE environments. Those use custom handlers, which I want to keep those consistent until 3.0.0 is released