Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow passing retry arguments down to gapic layer #247

Open
daniel-sanche opened this issue Mar 31, 2021 · 0 comments
Open

allow passing retry arguments down to gapic layer #247

daniel-sanche opened this issue Mar 31, 2021 · 0 comments
Labels
api: logging Issues related to the googleapis/python-logging API. logging-resilience priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@daniel-sanche
Copy link
Contributor

daniel-sanche commented Mar 31, 2021

The high-level, hand-written logger.log methods are the recommended way of interacting with the library, but they lose some of the power of the low-level, gapic methods. For example, gapic methods allow you to pass in custom "retry" logic. We should allow users to pass those arguments to the high-level methods, and pass them on down the stack

@daniel-sanche daniel-sanche added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. priority: p3 Desirable enhancement or fix. May not be included in next release. labels Mar 31, 2021
@daniel-sanche daniel-sanche added this to the v3.0.0 Breaking milestone Mar 31, 2021
@daniel-sanche daniel-sanche self-assigned this Mar 31, 2021
@product-auto-label product-auto-label bot added the api: logging Issues related to the googleapis/python-logging API. label Mar 31, 2021
@daniel-sanche daniel-sanche changed the title allow passing arguments down to gapic layer allow passing retry arguments down to gapic layer Oct 5, 2021
@daniel-sanche daniel-sanche modified the milestones: v3.0.0 Breaking, 4.0.0 Breaking Nov 16, 2021
@daniel-sanche daniel-sanche removed this from the 4.0.0 Breaking milestone Dec 13, 2022
@daniel-sanche daniel-sanche removed their assignment Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: logging Issues related to the googleapis/python-logging API. logging-resilience priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

No branches or pull requests

2 participants