fix: no duplicate logs on GCF or GAE #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: logging
google-cla
bot
added
the
cla: yes
daniel-sanche
force-pushed
the
test-duplicates
branch
from
a1e6678
to
407215d
Compare
daniel-sanche
changed the title
busunkim96
reviewed
Mar 11, 2021
daniel-sanche
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
0xSage
approved these changes
Mar 15, 2021
This was referenced Mar 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the library would send duplicate logs on certain environments, due to built-in logging handlers that would write to standard output. This PR removes those extra handlers as part of the
setup_loggingfunction now when detected.Also adds a test to ensure all platforms receive exactly one for each log
fixes #184