Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CloudLoggingHandler should infer the resource type #201

Closed
daniel-sanche opened this issue Mar 2, 2021 · 0 comments · Fixed by #200
Closed

CloudLoggingHandler should infer the resource type #201

daniel-sanche opened this issue Mar 2, 2021 · 0 comments · Fixed by #200
Assignees
@daniel-sanche
Labels
api: logging Issues related to the googleapis/python-logging API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Milestone
v2 Update 1

Comments

@daniel-sanche
Copy link
Contributor

We recently added resource auto-detection to the set up logging function. We should take this further and make it work even if the handler is created dynamically
@daniel-sanche daniel-sanche added this to the v2 Update 1 milestone Mar 2, 2021
@product-auto-label product-auto-label bot added the api: logging Issues related to the googleapis/python-logging API. label Mar 2, 2021
@daniel-sanche daniel-sanche linked a pull request Mar 2, 2021 that will close this issue
feat: detect monitored resources on all GCP environments #200
Merged
@daniel-sanche daniel-sanche mentioned this issue Mar 2, 2021
Merged
@yoshi-automation yoshi-automation added the triage me I really want to be triaged. label Mar 2, 2021
@daniel-sanche daniel-sanche added priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. and removed triage me I really want to be triaged. labels Mar 3, 2021
@daniel-sanche daniel-sanche self-assigned this Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@daniel-sanche daniel-sanche

Labels
api: logging Issues related to the googleapis/python-logging API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
v2 Update 1
Development

Successfully merging a pull request may close this issue.

feat: detect monitored resources on all GCP environments googleapis/python-logging
2 participants
@daniel-sanche @yoshi-automation