Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] Make ensure_ascii adjustable in ContainerEngineHandler #192

Closed
ysde opened this issue Feb 23, 2021 · 1 comment
Closed

[Enhancement] Make ensure_ascii adjustable in ContainerEngineHandler #192

ysde opened this issue Feb 23, 2021 · 1 comment
Assignees
@daniel-sanche
Labels
api: logging Issues related to the googleapis/python-logging API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Milestone
v2 Update 2

Comments

@ysde
Copy link
Contributor

ysde commented Feb 23, 2021

Thanks for stopping by to let us know something could be better!

PLEASE READ: If you have a support contract with Google, please create an issue in the support console instead of filing on GitHub. This will ensure a timely response.

Is your feature request related to a problem? Please describe.
Allow unicodes to show in log instead of ascii character (for example, show chinese word '哈' in log instead of something like '\u8bed')

Describe the solution you'd like
Add a constructor parameter json_ensure_ascii in class ContainerEngineHandler and add a parameter json_ensure_ascii in def format_stackdriver_json

Describe alternatives you've considered
Currently no...

Additional context
Nope
@product-auto-label product-auto-label bot added the api: logging Issues related to the googleapis/python-logging API. label Feb 23, 2021
@yoshi-automation yoshi-automation added triage me I really want to be triaged. 🚨 This issue needs some love. labels Feb 23, 2021
@daniel-sanche daniel-sanche added priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. and removed triage me I really want to be triaged. labels Mar 1, 2021
@yoshi-automation yoshi-automation removed the 🚨 This issue needs some love. label Mar 1, 2021
@daniel-sanche daniel-sanche added this to the v2 Update 1 milestone Mar 5, 2021
@daniel-sanche
Copy link
Contributor

Unicode support was added in #193, with more environment tests added in #267

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@daniel-sanche daniel-sanche

Labels
api: logging Issues related to the googleapis/python-logging API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
v2 Update 2
Development

No branches or pull requests
3 participants
@daniel-sanche @ysde @yoshi-automation