fix: add InternalServerError to list of expected errors #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: logging
google-cla
bot
added
the
cla: yes
busunkim96
reviewed
Jan 12, 2021
| @@ -67,7 +68,9 @@ def _list_entries(logger): | |||
| :returns: List of all entries consumed. | |||
| """ | |||
| inner = RetryResult(_has_entries, max_tries=9)(_consume_entries) | |||
| outer = RetryErrors((ServiceUnavailable, ResourceExhausted), max_tries=9)(inner) | |||
| outer = RetryErrors( | |||
There was a problem hiding this comment.
I think this is OK for the purposes of tests. For any changes to automatic retries in the client make sure to reference https://google.aip.dev/194 (it has guidance on error codes that should/shouldn't be retried).
There was a problem hiding this comment.
Good to know, thanks!
busunkim96
approved these changes
Jan 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are currently seeing a failure on the continuous CI tests for this repo. It looks like an internal server error is showing up on one of the list_logs calls. This fix adds that exception to the list of exceptions to retry