Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Pyramid support #139

Open
daniel-sanche opened this issue Dec 16, 2020 · 0 comments
Open

Add Pyramid support #139

daniel-sanche opened this issue Dec 16, 2020 · 0 comments
Labels
2023-triage api: logging Issues related to the googleapis/python-logging API. priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@daniel-sanche
Copy link
Contributor

daniel-sanche commented Dec 16, 2020 •
edited

It seems like a number of issue reports are coming from users using our library along with the Pyramid framework (#91). We should make it an officially supported library for capturing traces and http requests

Implementation would involve adding a new get_request_data_from_pyramid() function to /handlers/_helpers.py to capture http and trace data
@daniel-sanche daniel-sanche added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Dec 16, 2020
@daniel-sanche daniel-sanche self-assigned this Dec 16, 2020
@product-auto-label product-auto-label bot added the api: logging Issues related to the googleapis/python-logging API. label Dec 16, 2020
@daniel-sanche daniel-sanche mentioned this issue Dec 16, 2020
Closed
@daniel-sanche daniel-sanche mentioned this issue Jan 8, 2021
Closed
@daniel-sanche daniel-sanche added this to the v3.1.0 milestone Jan 27, 2021
@daniel-sanche daniel-sanche modified the milestones: v3 Update 1, v3 Update 2 Oct 5, 2021
@arbrown arbrown added priority: p3 Desirable enhancement or fix. May not be included in next release. and removed priority: p2 Moderately-important priority. Fix may not be included in next release. labels Jul 12, 2022
@daniel-sanche daniel-sanche removed this from the v3 Update 1 milestone Dec 13, 2022
@daniel-sanche daniel-sanche removed their assignment Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
2023-triage api: logging Issues related to the googleapis/python-logging API. priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@arbrown @daniel-sanche