Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove duplicate stream handler #106

Merged
merged 2 commits into from Dec 2, 2020
Merged

fix: remove duplicate stream handler #106

merged 2 commits into from Dec 2, 2020

Conversation

daniel-sanche
Copy link
Contributor

Remove extra StreamHandler. This was resulting in duplicate logs showing up on many GCP environments.
I tested this manually on our supported environments, and removing this doesn't have any negative impacts, and makes GKE and GAE standard much more usable

Fixes #38 馃

@daniel-sanche daniel-sanche requested review from a team as code owners November 24, 2020 19:32
@product-auto-label product-auto-label bot added the api: logging Issues related to the googleapis/python-logging API. label Nov 24, 2020
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 24, 2020
@daniel-sanche daniel-sanche self-assigned this Nov 24, 2020
@daniel-sanche daniel-sanche added the type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. label Nov 24, 2020
@daniel-sanche daniel-sanche mentioned this pull request Nov 24, 2020
Closed
4 tasks
chetan
chetan approved these changes Nov 30, 2020
View reviewed changes
Copy link

@chetan chetan left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I saw this issue as well. Alternatively, I was able to workaround this issue with the following - logging.getLogger().handlers.pop()

@daniel-sanche daniel-sanche mentioned this pull request Dec 1, 2020
Closed
@daniel-sanche daniel-sanche merged commit eb5cf40 into master Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chetan chetan chetan approved these changes

@0xSage 0xSage 0xSage approved these changes

Assignees

@daniel-sanche daniel-sanche

Labels
api: logging Issues related to the googleapis/python-logging API. cla: yes This human has signed the Contributor License Agreement. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add option to omit logging.StreamHandler during setup
3 participants
@daniel-sanche @chetan @0xSage