Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix logger documentation #100

Merged
merged 2 commits into from Nov 20, 2020
Merged

docs: fix logger documentation #100

merged 2 commits into from Nov 20, 2020

Conversation

busunkim96
Copy link
Contributor

@busunkim96 busunkim96 commented Nov 19, 2020 •
edited

image

Verified that the docs show up locally by doing nox -s docs

Fixes #99 馃

@busunkim96 busunkim96 requested review from a team as code owners November 19, 2020 20:15
@product-auto-label product-auto-label bot added the api: logging Issues related to the googleapis/python-logging API. label Nov 19, 2020
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 19, 2020
daniel-sanche
daniel-sanche approved these changes Nov 20, 2020
View reviewed changes
Copy link
Contributor

@daniel-sanche daniel-sanche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like lint is failing, but after that it LGTM!

@busunkim96 busunkim96 merged commit 6a46b46 into master Nov 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniel-sanche daniel-sanche daniel-sanche approved these changes

Assignees

@daniel-sanche daniel-sanche

Labels
api: logging Issues related to the googleapis/python-logging API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Logger not showing up in public docs
2 participants
@busunkim96 @daniel-sanche