Skip to content
This repository has been archived by the owner on Dec 31, 2023. It is now read-only.

feat(kms): add samples for new hmac and rng apis #161

Merged
merged 1 commit into from Aug 12, 2021
Merged

feat(kms): add samples for new hmac and rng apis #161

merged 1 commit into from Aug 12, 2021

Conversation

sethvargo
Copy link
Contributor

Adds samples for new Cloud KMS APIs.

@sethvargo sethvargo requested a review from a team as a code owner August 12, 2021 18:23
@product-auto-label product-auto-label bot added api: cloudkms Issues related to the googleapis/python-kms API. samples Issues that are directly related to samples. labels Aug 12, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 12, 2021
@snippet-bot
Copy link

snippet-bot bot commented Aug 12, 2021

Here is the summary of changes.

You are about to add 4 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@sethvargo
Copy link
Contributor Author

@kurtisvg updated. Just heads up: I don't have permissions to merge (even after tests pass). Can you merge assuming it's green again? Thanks!

@kurtisvg kurtisvg added the automerge Merge the pull request once unit tests and other checks pass. label Aug 12, 2021
@kurtisvg
Copy link
Contributor

@sethvargo I made a typo in my example - looks like it needs to be "FromTimedelta". I tried to update it myself, but since it's on a fork I didn't have permission.

@sethvargo
Copy link
Contributor Author

Updated. Yea, it's a fork. I don't have perms to push branches up to the main repo for python (but I do for Go and Node /shrug).

@kurtisvg kurtisvg merged commit 558b740 into googleapis:master Aug 12, 2021
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Aug 12, 2021
@sethvargo sethvargo deleted the sethvargo/kms_rng branch August 12, 2021 20:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api: cloudkms Issues related to the googleapis/python-kms API. cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants