Skip to content
This repository has been archived by the owner on Dec 31, 2023. It is now read-only.

feat!: generate with microgenerator #36

Merged
merged 8 commits into from Aug 11, 2020
Merged

feat!: generate with microgenerator #36

merged 8 commits into from Aug 11, 2020

Conversation

busunkim96
Copy link
Contributor

@busunkim96 busunkim96 commented Aug 5, 2020 •
edited

Todo:

  • remove google-specific credentials, scopes
  • fix generated unit tests

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 5, 2020
arithmetic1728
arithmetic1728 approved these changes Aug 6, 2020
View reviewed changes
setup.py Show resolved Hide resolved
@arithmetic1728
Copy link

may need to manually run a blacken nox session to fix the linter issue

@arithmetic1728
Copy link

LGTM

@google-cla
Copy link

google-cla bot commented Aug 11, 2020

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Aug 11, 2020
@arithmetic1728
Copy link

LGTM

@busunkim96 busunkim96 added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Aug 11, 2020
@busunkim96 busunkim96 merged commit 2785cc2 into master Aug 11, 2020
@release-please release-please bot mentioned this pull request Aug 11, 2020
Merged
@busunkim96 busunkim96 mentioned this pull request Aug 12, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@arithmetic1728 arithmetic1728 arithmetic1728 approved these changes

@software-dov software-dov Awaiting requested review from software-dov

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@busunkim96 @arithmetic1728