diff --git a/google/cloud/gkeconnect/gateway_v1beta1/services/gateway_service/async_client.py b/google/cloud/gkeconnect/gateway_v1beta1/services/gateway_service/async_client.py index bb88faf..d6f9834 100644 --- a/google/cloud/gkeconnect/gateway_v1beta1/services/gateway_service/async_client.py +++ b/google/cloud/gkeconnect/gateway_v1beta1/services/gateway_service/async_client.py @@ -830,6 +830,12 @@ async def patch_resource( # Done; return the response. return response + async def __aenter__(self): + return self + + async def __aexit__(self, exc_type, exc, tb): + await self.transport.close() + try: DEFAULT_CLIENT_INFO = gapic_v1.client_info.ClientInfo( diff --git a/google/cloud/gkeconnect/gateway_v1beta1/services/gateway_service/client.py b/google/cloud/gkeconnect/gateway_v1beta1/services/gateway_service/client.py index 578e0db..b85bd52 100644 --- a/google/cloud/gkeconnect/gateway_v1beta1/services/gateway_service/client.py +++ b/google/cloud/gkeconnect/gateway_v1beta1/services/gateway_service/client.py @@ -334,10 +334,7 @@ def __init__( client_cert_source_for_mtls=client_cert_source_func, quota_project_id=client_options.quota_project_id, client_info=client_info, - always_use_jwt_access=( - Transport == type(self).get_transport_class("grpc") - or Transport == type(self).get_transport_class("grpc_asyncio") - ), + always_use_jwt_access=True, ) def get_resource( @@ -1000,6 +997,19 @@ def patch_resource( # Done; return the response. return response + def __enter__(self): + return self + + def __exit__(self, type, value, traceback): + """Releases underlying transport's resources. + + .. warning:: + ONLY use as a context manager if the transport is NOT shared + with other clients! Exiting the with block will CLOSE the transport + and may cause errors in other clients! + """ + self.transport.close() + try: DEFAULT_CLIENT_INFO = gapic_v1.client_info.ClientInfo( diff --git a/google/cloud/gkeconnect/gateway_v1beta1/services/gateway_service/transports/base.py b/google/cloud/gkeconnect/gateway_v1beta1/services/gateway_service/transports/base.py index d208850..09cc4b3 100644 --- a/google/cloud/gkeconnect/gateway_v1beta1/services/gateway_service/transports/base.py +++ b/google/cloud/gkeconnect/gateway_v1beta1/services/gateway_service/transports/base.py @@ -171,6 +171,15 @@ def _prep_wrapped_messages(self, client_info): ), } + def close(self): + """Closes resources associated with the transport. + + .. warning:: + Only call this method if the transport is NOT shared + with other clients - this may cause errors in other clients! + """ + raise NotImplementedError() + @property def get_resource( self, diff --git a/google/cloud/gkeconnect/gateway_v1beta1/services/gateway_service/transports/grpc.py b/google/cloud/gkeconnect/gateway_v1beta1/services/gateway_service/transports/grpc.py index 8942160..5da9bc8 100644 --- a/google/cloud/gkeconnect/gateway_v1beta1/services/gateway_service/transports/grpc.py +++ b/google/cloud/gkeconnect/gateway_v1beta1/services/gateway_service/transports/grpc.py @@ -359,5 +359,8 @@ def patch_resource( ) return self._stubs["patch_resource"] + def close(self): + self.grpc_channel.close() + __all__ = ("GatewayServiceGrpcTransport",) diff --git a/google/cloud/gkeconnect/gateway_v1beta1/services/gateway_service/transports/grpc_asyncio.py b/google/cloud/gkeconnect/gateway_v1beta1/services/gateway_service/transports/grpc_asyncio.py index 4010863..1b6c525 100644 --- a/google/cloud/gkeconnect/gateway_v1beta1/services/gateway_service/transports/grpc_asyncio.py +++ b/google/cloud/gkeconnect/gateway_v1beta1/services/gateway_service/transports/grpc_asyncio.py @@ -368,5 +368,8 @@ def patch_resource( ) return self._stubs["patch_resource"] + def close(self): + return self.grpc_channel.close() + __all__ = ("GatewayServiceGrpcAsyncIOTransport",) diff --git a/tests/unit/gapic/gateway_v1beta1/test_gateway_service.py b/tests/unit/gapic/gateway_v1beta1/test_gateway_service.py index 6d11b18..de30a63 100644 --- a/tests/unit/gapic/gateway_v1beta1/test_gateway_service.py +++ b/tests/unit/gapic/gateway_v1beta1/test_gateway_service.py @@ -30,6 +30,7 @@ from google.api_core import gapic_v1 from google.api_core import grpc_helpers from google.api_core import grpc_helpers_async +from google.api_core import path_template from google.auth import credentials as ga_credentials from google.auth.exceptions import MutualTLSChannelError from google.cloud.gkeconnect.gateway_v1beta1.services.gateway_service import ( @@ -1100,6 +1101,9 @@ def test_gateway_service_base_transport(): with pytest.raises(NotImplementedError): getattr(transport, method)(request=object()) + with pytest.raises(NotImplementedError): + transport.close() + @requires_google_auth_gte_1_25_0 def test_gateway_service_base_transport_with_credentials_file(): @@ -1558,3 +1562,49 @@ def test_client_withDEFAULT_CLIENT_INFO(): credentials=ga_credentials.AnonymousCredentials(), client_info=client_info, ) prep.assert_called_once_with(client_info) + + +@pytest.mark.asyncio +async def test_transport_close_async(): + client = GatewayServiceAsyncClient( + credentials=ga_credentials.AnonymousCredentials(), transport="grpc_asyncio", + ) + with mock.patch.object( + type(getattr(client.transport, "grpc_channel")), "close" + ) as close: + async with client: + close.assert_not_called() + close.assert_called_once() + + +def test_transport_close(): + transports = { + "grpc": "_grpc_channel", + } + + for transport, close_name in transports.items(): + client = GatewayServiceClient( + credentials=ga_credentials.AnonymousCredentials(), transport=transport + ) + with mock.patch.object( + type(getattr(client.transport, close_name)), "close" + ) as close: + with client: + close.assert_not_called() + close.assert_called_once() + + +def test_client_ctx(): + transports = [ + "grpc", + ] + for transport in transports: + client = GatewayServiceClient( + credentials=ga_credentials.AnonymousCredentials(), transport=transport + ) + # Test client calls underlying transport. + with mock.patch.object(type(client.transport), "close") as close: + close.assert_not_called() + with client: + pass + close.assert_called()