Skip to content
This repository has been archived by the owner on Nov 8, 2023. It is now read-only.

Add samples for game server deployments #25

Merged
merged 7 commits into from Jul 24, 2020
Merged

Add samples for game server deployments #25

merged 7 commits into from Jul 24, 2020

Conversation

Yingxin-Jiang
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • [*] Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
    Add code samples for game servers #24
  • [*] Ensure the tests and linter pass
    Done
  • Code coverage does not decrease (if any source code was changed)
    N/A
  • [*] Appropriate docs were updated (if necessary)
    Done

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 17, 2020
@busunkim96 busunkim96 self-requested a review July 17, 2020 18:46
busunkim96
busunkim96 suggested changes Jul 20, 2020
View reviewed changes
samples/snippets/create_deployment.py Outdated Show resolved Hide resolved
samples/snippets/deployment_test.py Outdated Show resolved Hide resolved
samples/snippets/deployment_test.py Outdated Show resolved Hide resolved
samples/snippets/update_rollout_remove_default.py Show resolved Hide resolved
@busunkim96 busunkim96 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 22, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 22, 2020
busunkim96
busunkim96 reviewed Jul 23, 2020
View reviewed changes
samples/snippets/requirements.txt Outdated Show resolved Hide resolved
samples/snippets/deployment_test.py Outdated Show resolved Hide resolved
@busunkim96 busunkim96 added kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jul 24, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 24, 2020
@Yingxin-Jiang
Copy link
Contributor Author

Thanks for reviewing!

@Yingxin-Jiang Yingxin-Jiang reopened this Jul 24, 2020
@busunkim96 busunkim96 merged commit a3dee35 into googleapis:master Jul 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@busunkim96 busunkim96 busunkim96 approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Yingxin-Jiang @busunkim96 @yoshi-kokoro