Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise Test Coverage #92

Closed
crwilcox opened this issue Jul 13, 2020 · 0 comments · Fixed by #225
Closed

Raise Test Coverage #92

crwilcox opened this issue Jul 13, 2020 · 0 comments · Fixed by #225
Assignees
@HemangChothani
Labels
api: firestore Issues related to the googleapis/python-firestore API. help wanted We'd love to have community involvement on this issue. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. release blocking Required feature/issue must be fixed prior to next release.

Comments

@crwilcox
Copy link
Contributor

In order to expedite merging in a new microgenerated surface, coverage was dropped from 100% to 97%.
https://github.com/googleapis/python-firestore/tree/v2-staging
#91

This work item tracks raising it back up again.

Name                                                                                  Stmts   Miss Branch BrPart  Cover   Missing
---------------------------------------------------------------------------------------------------------------------------------
google/cloud/__init__.py                                                                  6      6      0      0     0%   15-22
google/cloud/firestore.py                                                                26      0      0      0   100%
google/cloud/firestore_admin_v1/__init__.py                                              23      0      0      0   100%
google/cloud/firestore_admin_v1/services/__init__.py                                      0      0      0      0   100%
google/cloud/firestore_admin_v1/services/firestore_admin/__init__.py                      3      0      0      0   100%
google/cloud/firestore_admin_v1/services/firestore_admin/async_client.py                137      2     38      0    99%   882-883
google/cloud/firestore_admin_v1/services/firestore_admin/client.py                      195      2     64      0    99%   1030-1031
google/cloud/firestore_admin_v1/services/firestore_admin/pagers.py                       82      0     20      0   100%
google/cloud/firestore_admin_v1/services/firestore_admin/transports/__init__.py           9      0      0      0   100%
google/cloud/firestore_admin_v1/services/firestore_admin/transports/base.py              45      0      8      0   100%
google/cloud/firestore_admin_v1/services/firestore_admin/transports/grpc.py              90      0     30      0   100%
google/cloud/firestore_admin_v1/services/firestore_admin/transports/grpc_asyncio.py      90      0     28      0   100%
google/cloud/firestore_admin_v1/types/__init__.py                                         6      0      0      0   100%
google/cloud/firestore_admin_v1/types/field.py                                           12      0      0      0   100%
google/cloud/firestore_admin_v1/types/firestore_admin.py                                 48      0      0      0   100%
google/cloud/firestore_admin_v1/types/index.py                                           28      0      0      0   100%
google/cloud/firestore_admin_v1/types/location.py                                         4      0      0      0   100%
google/cloud/firestore_admin_v1/types/operation.py                                       57      0      0      0   100%
google/cloud/firestore_v1/__init__.py                                                    27      0      0      0   100%
google/cloud/firestore_v1/_helpers.py                                                   396      5    222      8    98%   585->586, 586, 592->595, 617->618, 618, 794->799, 818->819, 819, 826->827, 827, 868->873, 875->878, 878
google/cloud/firestore_v1/base_batch.py                                                  26      0      4      0   100%
google/cloud/firestore_v1/base_client.py                                                131      2     38      1    98%   164->167, 167, 481
google/cloud/firestore_v1/base_collection.py                                             75      0     12      0   100%
google/cloud/firestore_v1/base_document.py                                              106      1     20      0    99%   460
google/cloud/firestore_v1/base_query.py                                                 279     19    128      0    93%   787-824
google/cloud/firestore_v1/batch.py                                                       16      0      2      0   100%
google/cloud/firestore_v1/client.py                                                      34      1      6      1    95%   244->245, 245
google/cloud/firestore_v1/collection.py                                                  29      0      4      0   100%
google/cloud/firestore_v1/document.py                                                    57      1      8      1    97%   373->374, 374
google/cloud/firestore_v1/field_path.py                                                 138      2     56      0    99%   19-20
google/cloud/firestore_v1/order.py                                                      129      0     54      0   100%
google/cloud/firestore_v1/query.py                                                       23      0      6      0   100%
google/cloud/firestore_v1/services/__init__.py                                            0      0      0      0   100%
google/cloud/firestore_v1/services/firestore/__init__.py                                  3      0      0      0   100%
google/cloud/firestore_v1/services/firestore/async_client.py                            155      2     30      0    99%   1060-1061
google/cloud/firestore_v1/services/firestore/client.py                                  200      2     56      0    99%   1171-1172
google/cloud/firestore_v1/services/firestore/pagers.py                                   82      0     20      0   100%
google/cloud/firestore_v1/services/firestore/transports/__init__.py                       9      0      0      0   100%
google/cloud/firestore_v1/services/firestore/transports/base.py                          53      0      8      0   100%
google/cloud/firestore_v1/services/firestore/transports/grpc.py                         113      0     40      0   100%
google/cloud/firestore_v1/services/firestore/transports/grpc_asyncio.py                 113      0     38      0   100%
google/cloud/firestore_v1/transaction.py                                                126      0     28      0   100%
google/cloud/firestore_v1/transforms.py                                                  39      0     10      0   100%
google/cloud/firestore_v1/types/__init__.py                                               6      0      0      0   100%
google/cloud/firestore_v1/types/common.py                                                16      0      0      0   100%
google/cloud/firestore_v1/types/document.py                                              27      0      0      0   100%
google/cloud/firestore_v1/types/firestore.py                                            157      1      0      0    99%   1019
google/cloud/firestore_v1/types/query.py                                                 62      0      0      0   100%
google/cloud/firestore_v1/types/write.py                                                 45      0      0      0   100%
google/cloud/firestore_v1/watch.py                                                      325      3     78      2    99%   397->exit, 524->525, 525-527
google/cloud/firestore_v1beta1/__init__.py                                               63      0      0      0   100%
google/cloud/firestore_v1beta1/_helpers.py                                              387      5    216      8    98%   537->538, 538, 544->547, 569->570, 570, 746->751, 770->771, 771, 778->779, 779, 820->825, 827->830, 830
google/cloud/firestore_v1beta1/batch.py                                                  37      0      6      0   100%
google/cloud/firestore_v1beta1/client.py                                                119      0     26      0   100%
google/cloud/firestore_v1beta1/collection.py                                            100      0     14      0   100%
google/cloud/firestore_v1beta1/document.py                                              149      0     24      0   100%
google/cloud/firestore_v1beta1/field_path.py                                            135      2     56      0    99%   19-20
google/cloud/firestore_v1beta1/order.py                                                 129      0     54      0   100%
google/cloud/firestore_v1beta1/query.py                                                 257      0    116      0   100%
google/cloud/firestore_v1beta1/services/__init__.py                                       0      0      0      0   100%
google/cloud/firestore_v1beta1/services/firestore/__init__.py                             3      0      0      0   100%
google/cloud/firestore_v1beta1/services/firestore/async_client.py                       140      2     30      0    99%   942-943
google/cloud/firestore_v1beta1/services/firestore/client.py                             185      2     56      0    99%   1055-1056
google/cloud/firestore_v1beta1/services/firestore/pagers.py                              42      0     10      0   100%
google/cloud/firestore_v1beta1/services/firestore/transports/__init__.py                  9      0      0      0   100%
google/cloud/firestore_v1beta1/services/firestore/transports/base.py                     49      0      8      0   100%
google/cloud/firestore_v1beta1/services/firestore/transports/grpc.py                    103      0     36      0   100%
google/cloud/firestore_v1beta1/services/firestore/transports/grpc_asyncio.py            103      0     34      0   100%
google/cloud/firestore_v1beta1/transaction.py                                           116      0     24      0   100%
google/cloud/firestore_v1beta1/transforms.py                                             24      0      6      0   100%
google/cloud/firestore_v1beta1/types/__init__.py                                          6      0      0      0   100%
google/cloud/firestore_v1beta1/types/common.py                                           16      0      0      0   100%
google/cloud/firestore_v1beta1/types/document.py                                         27      0      0      0   100%
google/cloud/firestore_v1beta1/types/firestore.py                                       138      1      0      0    99%   909
google/cloud/firestore_v1beta1/types/query.py                                            62      0      0      0   100%
google/cloud/firestore_v1beta1/types/write.py                                            44      0      0      0   100%
google/cloud/firestore_v1beta1/watch.py                                                 310      3     74      2    99%   383->exit, 507->508, 508-510
tests/unit/__init__.py                                                                    0      0      0      0   100%
tests/unit/test_firestore_shim.py                                                        10      0      2      0   100%
tests/unit/v1/__init__.py                                                                 0      0      0      0   100%
tests/unit/v1/_test_cross_language.py                                                   199    199     80      0     0%   17-518
tests/unit/v1/test__helpers.py                                                         1545      0     32      0   100%
tests/unit/v1/test_base_batch.py                                                         98      0      0      0   100%
tests/unit/v1/test_base_client.py                                                       213      0      0      0   100%
tests/unit/v1/test_base_collection.py                                                   226      0      0      0   100%
tests/unit/v1/test_base_document.py                                                     290      0      2      0   100%
tests/unit/v1/test_base_query.py                                                        942      1     20      1    99%   24->25, 25
tests/unit/v1/test_batch.py                                                              81      0      0      0   100%
tests/unit/v1/test_client.py                                                            270      3      4      0    98%   211-213
tests/unit/v1/test_collection.py                                                        186      0     10      0   100%
tests/unit/v1/test_document.py                                                          275      3     30      0    98%   430-432
tests/unit/v1/test_field_path.py                                                        355      0      8      0   100%
tests/unit/v1/test_order.py                                                             143      2     12      2    97%   31->32, 32, 215->216, 216
tests/unit/v1/test_query.py                                                             196      1      2      1    99%   26->27, 27
tests/unit/v1/test_transaction.py                                                       574      0      0      0   100%
tests/unit/v1/test_transforms.py                                                         78      0      8      0   100%
tests/unit/v1/test_watch.py                                                             667      0      4      0   100%
tests/unit/v1beta1/__init__.py                                                            0      0      0      0   100%
tests/unit/v1beta1/_test_cross_language.py                                              192    192     78      0     0%   15-503
tests/unit/v1beta1/test__helpers.py                                                    1298      0     32      0   100%
tests/unit/v1beta1/test_batch.py                                                        158      0      0      0   100%
tests/unit/v1beta1/test_client.py                                                       398      0      4      0   100%
tests/unit/v1beta1/test_collection.py                                                   375      0     12      0   100%
tests/unit/v1beta1/test_document.py                                                     525      0     32      0   100%
tests/unit/v1beta1/test_field_path.py                                                   351      0      8      0   100%
tests/unit/v1beta1/test_order.py                                                        143      2     12      2    97%   31->32, 32, 215->216, 216
tests/unit/v1beta1/test_query.py                                                       1004      1     20      1    99%   26->27, 27
tests/unit/v1beta1/test_transaction.py                                                  546      0      0      0   100%
tests/unit/v1beta1/test_transforms.py                                                    40      0      2      0   100%
tests/unit/v1beta1/test_watch.py                                                        565      1      2      0    99%   849
---------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                                                 18554    469   2262     30    97%
Coverage failure: total of 97 is less than fail-under=100
@crwilcox crwilcox added api: firestore Issues related to the googleapis/python-firestore API. release blocking Required feature/issue must be fixed prior to next release. labels Jul 13, 2020
@yoshi-automation yoshi-automation added the triage me I really want to be triaged. label Jul 14, 2020
@crwilcox crwilcox added priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. and removed triage me I really want to be triaged. labels Jul 16, 2020
@crwilcox crwilcox changed the title Raise Test Coverage for v2-staging branch Raise Test Coverage Sep 17, 2020
@crwilcox crwilcox mentioned this issue Sep 17, 2020
Merged
@crwilcox crwilcox added the help wanted We'd love to have community involvement on this issue. label Sep 17, 2020
@HemangChothani HemangChothani self-assigned this Sep 21, 2020
@HemangChothani HemangChothani mentioned this issue Sep 22, 2020
Closed
@tseaver tseaver mentioned this issue Sep 22, 2020
Closed
tseaver added a commit that referenced this issue Sep 22, 2020
@tseaver
chore: let synth generate .coveragerc
727b3c0 
Toward #92.
@tseaver tseaver mentioned this issue Sep 22, 2020
Merged
tseaver added a commit that referenced this issue Sep 24, 2020
@tseaver @crwilcox
chore: let synth generate .coveragerc (#196)
0336110 
Toward #92.

Co-authored-by: Christopher Wilcox <crwilcox@google.com>
@HemangChothani HemangChothani linked a pull request Oct 1, 2020 that will close this issue
test: raise coverage #195
Closed
@tseaver tseaver mentioned this issue Oct 22, 2020
Merged
gcf-merge-on-green bot pushed a commit that referenced this issue Oct 23, 2020
@tseaver
chore: restore coverage (almost) to 100% (#225)
e8f6c4d 
Note that the synthtool-generated `.coveragerc` (see #224) does *not* include all changes needed for 100% coverage:  see:

- googleapis/gapic-generator-python#171
- googleapis/gapic-generator-python#437

Closes #92.
Closes #195.
@tseaver tseaver mentioned this issue Oct 26, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@HemangChothani HemangChothani

Labels
api: firestore Issues related to the googleapis/python-firestore API. help wanted We'd love to have community involvement on this issue. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. release blocking Required feature/issue must be fixed prior to next release.
Projects
None yet
Milestone
No milestone
3 participants
@crwilcox @yoshi-automation @HemangChothani