Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: Begin using new microgenerator for v2 firestore #91

Merged
merged 15 commits into from Jul 14, 2020
Merged

feat!: Begin using new microgenerator for v2 firestore #91

merged 15 commits into from Jul 14, 2020

Conversation

crwilcox
Copy link
Contributor

Commits early on split off to separate out generated bits from edits to (hopefully) ease reviewing

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 10, 2020
@crwilcox crwilcox mentioned this pull request Jul 10, 2020
Closed
@crwilcox
Copy link
Contributor Author

Kokoro Test is Skipping System, which is odd, running locally.

@crwilcox
Copy link
Contributor Author

Coverage is at 97%, not 100%. Considering, temporarily, dropping this and filing an issue. Docs issue tbd.

@crwilcox crwilcox mentioned this pull request Jul 13, 2020
Closed
@crwilcox crwilcox requested a review from rafilong July 13, 2020 15:40
@crwilcox
Copy link
Contributor Author

I recommend viewing a selection of commits to make this a bit more palatable: https://github.com/googleapis/python-firestore/pull/91/files/538cb05b70c96a637c1b12cf0c69a2925fc45686..94210e3625b63a40a7e76698eba529e8ab3da0a3

@crwilcox crwilcox mentioned this pull request Jul 13, 2020
Merged
rafilong
rafilong reviewed Jul 13, 2020
View reviewed changes
.flake8 Outdated Show resolved Hide resolved
synth.py Outdated Show resolved Hide resolved
synth.py Show resolved Hide resolved
rafilong
rafilong reviewed Jul 13, 2020
View reviewed changes
.kokoro/publish-docs.sh Show resolved Hide resolved
synth.py Show resolved Hide resolved
rafilong
rafilong reviewed Jul 13, 2020
View reviewed changes
Copy link
Contributor

@rafilong rafilong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Most of the comments I had were clarifying confusion on my end.

google/cloud/firestore_v1/__init__.py Outdated Show resolved Hide resolved
google/cloud/firestore_v1/__init__.py Show resolved Hide resolved
google/cloud/firestore_v1/base_collection.py Show resolved Hide resolved
google/cloud/firestore_v1/base_document.py Outdated Show resolved Hide resolved
google/cloud/firestore_v1/base_query.py Outdated Show resolved Hide resolved
tests/unit/v1/test_collection.py Outdated Show resolved Hide resolved
tests/unit/v1/test_document.py Show resolved Hide resolved
tests/unit/v1/test_transaction.py Outdated Show resolved Hide resolved
tests/unit/v1/test_watch.py Show resolved Hide resolved
tests/unit/v1/test_watch.py Show resolved Hide resolved
rafilong
rafilong reviewed Jul 14, 2020
View reviewed changes
google/cloud/firestore_v1/order.py Outdated Show resolved Hide resolved
google/cloud/firestore_v1/order.py Show resolved Hide resolved
rafilong
rafilong approved these changes Jul 14, 2020
View reviewed changes
Copy link
Contributor

@rafilong rafilong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@crwilcox crwilcox merged commit e0add08 into googleapis:v2-staging Jul 14, 2020
@release-please release-please bot mentioned this pull request Aug 20, 2020
Closed
@release-please release-please bot mentioned this pull request Aug 20, 2020
Closed
@tseaver tseaver mentioned this pull request Aug 20, 2020
Merged
1 task
This was referenced Aug 20, 2020
Closed
Closed
Merged
Closed
This was referenced Oct 26, 2020
Closed
Closed
Merged
Closed
This was referenced Nov 3, 2020
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tseaver tseaver tseaver left review comments

@rafilong rafilong rafilong approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@crwilcox @tseaver @rafilong @googlebot