Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add streaming retries to BatchGetDocuments #890

Open
daniel-sanche opened this issue Mar 13, 2024 · 0 comments
Open

Add streaming retries to BatchGetDocuments #890

daniel-sanche opened this issue Mar 13, 2024 · 0 comments
Assignees
@daniel-sanche
Labels
api: firestore Issues related to the googleapis/python-firestore API. priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Milestone
Retry Audit

Comments

@daniel-sanche
Copy link
Contributor

Similar to #889

Unlike the others, BatchGetDocuments never supported any kind of streaming retries. When the stream fails, an exception is raised

We should also add stream recovery to this rpc
@daniel-sanche daniel-sanche added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. priority: p3 Desirable enhancement or fix. May not be included in next release. labels Mar 13, 2024
@daniel-sanche daniel-sanche added this to the Retry Audit milestone Mar 13, 2024
@daniel-sanche daniel-sanche self-assigned this Mar 13, 2024
@product-auto-label product-auto-label bot added the api: firestore Issues related to the googleapis/python-firestore API. label Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@daniel-sanche daniel-sanche

Labels
api: firestore Issues related to the googleapis/python-firestore API. priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
Retry Audit
Development

No branches or pull requests
1 participant
@daniel-sanche