Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

page_size not needed for list_documents #887

Open
daniel-sanche opened this issue Mar 12, 2024 · 0 comments
Open

page_size not needed for list_documents #887

daniel-sanche opened this issue Mar 12, 2024 · 0 comments
Assignees
Labels
api: firestore Issues related to the googleapis/python-firestore API. priority: p3 Desirable enhancement or fix. May not be included in next release. type: cleanup An internal cleanup or hygiene concern.
Milestone

Comments

@daniel-sanche
Copy link
Contributor

We have three rpcs that use pagers: ListDocuments, ListCollectionIds, and PartitionQuery

Currently, onlt list_documents provides the user with a customizable page_size arg. But all 3 rpcs abstract the pages from the users, and provide them with a flat generator over the underlying resources, so it's debatable whether the page_size argument even makes sense to provide.

To be consistent, we should either remove it from list_documents, or provide it in all three

@daniel-sanche daniel-sanche added type: cleanup An internal cleanup or hygiene concern. priority: p3 Desirable enhancement or fix. May not be included in next release. labels Mar 12, 2024
@daniel-sanche daniel-sanche added this to the Retry Audit milestone Mar 12, 2024
@daniel-sanche daniel-sanche self-assigned this Mar 12, 2024
@product-auto-label product-auto-label bot added the api: firestore Issues related to the googleapis/python-firestore API. label Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: firestore Issues related to the googleapis/python-firestore API. priority: p3 Desirable enhancement or fix. May not be included in next release. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Development

No branches or pull requests

1 participant