Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

can't disable timeouts in rpc calls #885

Open
daniel-sanche opened this issue Mar 12, 2024 · 0 comments
Open

can't disable timeouts in rpc calls #885

daniel-sanche opened this issue Mar 12, 2024 · 0 comments
Assignees
@daniel-sanche
Labels
api: firestore Issues related to the googleapis/python-firestore API. priority: p3 Desirable enhancement or fix. May not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Milestone
Retry Audit

Comments

@daniel-sanche
Copy link
Contributor

daniel-sanche commented Mar 12, 2024 •
edited

Most rpc calls support passing in a retry and timeout value to configure retry parameters (example: WriteBatch.commit)

But when timeout=None, that means it uses the api default, meaning there is no way to truly disable timeouts

That said, fixing this would likely be a breaking change, and timeout can always be set arbitrarily high, so this is a low-priority fix
@daniel-sanche daniel-sanche added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p3 Desirable enhancement or fix. May not be included in next release. labels Mar 12, 2024
@daniel-sanche daniel-sanche added this to the Retry Audit milestone Mar 12, 2024
@daniel-sanche daniel-sanche self-assigned this Mar 12, 2024
@product-auto-label product-auto-label bot added the api: firestore Issues related to the googleapis/python-firestore API. label Mar 12, 2024
@daniel-sanche daniel-sanche changed the title commit calls can't disable timeouts can't disable timeouts in rpc calls Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@daniel-sanche daniel-sanche

Labels
api: firestore Issues related to the googleapis/python-firestore API. priority: p3 Desirable enhancement or fix. May not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
Retry Audit
Development

No branches or pull requests
1 participant
@daniel-sanche