Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace transaction retries with api_core implementation #878

Open
daniel-sanche opened this issue Mar 9, 2024 · 0 comments
Open

Replace transaction retries with api_core implementation #878

daniel-sanche opened this issue Mar 9, 2024 · 0 comments
Assignees
@daniel-sanche
Labels
api: firestore Issues related to the googleapis/python-firestore API. priority: p3 Desirable enhancement or fix. May not be included in next release.
Milestone
Retry Audit

Comments

@daniel-sanche
Copy link
Contributor

Transaction-level retries currently use a hand-rolled implementation within Transactional.call, AsyncTransactional.call, and _commit_with_retry

We should replace these with the standard api_core.Retry gunctionality, to remove duplicated code
@daniel-sanche daniel-sanche added the priority: p3 Desirable enhancement or fix. May not be included in next release. label Mar 9, 2024
@daniel-sanche daniel-sanche added this to the Retry Audit milestone Mar 9, 2024
@daniel-sanche daniel-sanche self-assigned this Mar 9, 2024
@product-auto-label product-auto-label bot added the api: firestore Issues related to the googleapis/python-firestore API. label Mar 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@daniel-sanche daniel-sanche

Labels
api: firestore Issues related to the googleapis/python-firestore API. priority: p3 Desirable enhancement or fix. May not be included in next release.
Projects
None yet
Milestone
Retry Audit
Development

No branches or pull requests
1 participant
@daniel-sanche