Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add System Test that gets collections #84

Closed
crwilcox opened this issue Jul 7, 2020 · 0 comments · Fixed by #88
Closed

Add System Test that gets collections #84

crwilcox opened this issue Jul 7, 2020 · 0 comments · Fixed by #88
Assignees
@IlyaFaer
Labels
api: firestore Issues related to the googleapis/python-firestore API. good first issue This issue is a good place to started contributing to this repository. type: process A process-related concern. May include testing, release, or the like.

Comments

@crwilcox
Copy link
Contributor

crwilcox commented Jul 7, 2020

We were able to release v1.8.0 without a failure, despite missing an import.

#83, #82

We should add the following test

from google.cloud import firestore
db=firestore.Client()
collections = [i for i in db.collections()]

If that doesn't fail, 👍
@product-auto-label product-auto-label bot added the api: firestore Issues related to the googleapis/python-firestore API. label Jul 7, 2020
@crwilcox crwilcox added the good first issue This issue is a good place to started contributing to this repository. label Jul 7, 2020
@yoshi-automation yoshi-automation added the triage me I really want to be triaged. label Jul 7, 2020
@IlyaFaer IlyaFaer self-assigned this Jul 8, 2020
@IlyaFaer IlyaFaer added type: process A process-related concern. May include testing, release, or the like. and removed triage me I really want to be triaged. labels Jul 8, 2020
@IlyaFaer IlyaFaer mentioned this issue Jul 9, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@IlyaFaer IlyaFaer

Labels
api: firestore Issues related to the googleapis/python-firestore API. good first issue This issue is a good place to started contributing to this repository. type: process A process-related concern. May include testing, release, or the like.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: add imports into test_collections systest MaxxleLLC/python-firestore
3 participants
@crwilcox @IlyaFaer @yoshi-automation