Adding Async Client to Google-Cloud-Firestore

[crwilcox]

No description provided.

[skgbanga]

Hello,

I noticed that https://github.com/googleapis/python-firestore/releases/tag/v2.0.0-dev1 added support for async.
Do you think support is stable enough for production usage?

[crwilcox]

@skgbanga I would say so, though I have left it in dev to allow early usage and a fallback in case we find issues. I was planning to release v2.0.0-dev to v2.0.0 in its state this month. I currently anticipate no changes.

[NixBiks]

Really appreciate the new support of AsyncClient !

One issue though. It doesn't work with the firestore emulator. The following script raises and exception

TypeError: Unexpected type of call <class 'google.cloud.firestore_v1.types.firestore.CommitResponse'>

Start the firestore emulator and run the script

import asyncio
from google.cloud.firestore import AsyncClient
import os


os.environ["FIRESTORE_EMULATOR_HOST"] = "localhost:8080"

client = AsyncClient()


async def save():
    return (
        await client.collection("test")
        .document("test")
        .set({"message": "Hello World!"})
    )


if __name__ == "__main__":
    loop = asyncio.get_event_loop()
    loop.run_until_complete(save())

The same issue goes for retrieving data.

[samuelstroschein]

@crwilcox Is there a timeline when listening for realtime updates/streaming is supported with asyncio?

[crwilcox]

I don't have a timeline to share at this time. This is on the backlog though.

[NixBiks]

What about async support for the emulator?

And is there a workaround until it's fixed? I'm using the emulator for testing purposes

[crwilcox]

@mr-bjerre I am not sure I follow. I don't expect the emulator to require any changes. The Async changes are part of grpcio and the firestore client. The API surface hasn't been altered.

[NixBiks]

@crwilcox not sure I understand what that means exactly? Have you seen my code example above? I'm getting exceptions when using the AsyncClient in combination with the firestore emulator. You don't?

[crwilcox]

@mr-bjerre I think my confusion is that you are raising a new issue, not about the addition of an async interface. I created a separate tracking issue.

As the only part of this issue that remains is watch clients, and that is spun off as #131 I am closing this issue.